Producing good error messages is such hard work!
Instead of 0%3o, use 0%03o
Since you want to print the lowest 9 bits of the mode, don't you want & 0x1ff
On Wed, Mar 11, 2015 at 2:30 AM, Staffan Larsen
wrote:
> Thanks for the feedback. Here is a new version that prints out more
> details for
Hi all,
So I think we can remove _jvmti_force_gc from is_user_requested_gc() and add
_dcmd_gc_run
to it.
I've uploaded new webrev, and I've applied it to new patch.
Could you review it?
http://cr.openjdk.java.net/~ysuenaga/JDK-8072913/webrev.01/
I also updated jtreg testcase.
It works fine
On 11.3.2015 13:38, Staffan Larsen wrote:
Please review this addition of a missing @.
Thumbs up!
-JB-
/Staffan
diff --git
a/src/java.management/share/classes/com/sun/management/DiagnosticCommandMBean.java
b/src/java.management/share/classes/com/sun/management/DiagnosticCommandMBean.jav
Please review this addition of a missing @.
/Staffan
diff --git
a/src/java.management/share/classes/com/sun/management/DiagnosticCommandMBean.java
b/src/java.management/share/classes/com/sun/management/DiagnosticCommandMBean.java
---
a/src/java.management/share/classes/com/sun/management/Dia
Let try this!
/Staffan
> On 11 mar 2015, at 09:35, Jaroslav Bachorik
> wrote:
>
> On 5.3.2015 11:37, Jaroslav Bachorik wrote:
>> Please, review the following change
>>
>> Issue : https://bugs.openjdk.java.net/browse/JDK-8074041
>> Webrev: http://cr.openjdk.java.net/~jbachorik/8074041/webrev.0
Thanks for the feedback. Here is a new version that prints out more details for
each of the errors messages. Let me know if you have suggestions for better
wording. It also adds an #include for jvm.h that was missing from some of the
files (it is needed for jio_snprintf).
webrev: http://cr.open
Hi Jaroslav,
That's exactly the functionality I've been looking for! Not only it will
solveJDK-8074041 the ProcessImpl will help me to solve
https://bugs.openjdk.java.net/browse/JDK-8073794 since I'll be able to
analyse out and err streams outside startProcess() function.
Best regards,
Katja
On 5.3.2015 11:37, Jaroslav Bachorik wrote:
Please, review the following change
Issue : https://bugs.openjdk.java.net/browse/JDK-8074041
Webrev: http://cr.openjdk.java.net/~jbachorik/8074041/webrev.00
This test fails very intermittently still and the failure is very hard
to reproduce. Based on
Looks good!
Thanks,
/Staffan
> On 10 mar 2015, at 22:02, Markus Gronlund wrote:
>
> Greetings,
>
>
>
> Please review this small update to the Visual Studio projectcreator.make in
> order to exclude aarch64 files.
>
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8074905
>
> Webrev:
