Re: Please review draft JEP: JMX Specific Annotations for Registration of Managed Resources

2015-03-18 Thread Eamonn McManus
> Mainly because the long term goal (beyond the scope of this JEP, anyway) > would be to get users to slowly migrate to the annotation based M(X)Beans. > Not giving them the chance to specify the service interface via annotations > will mean keeping this dichotomy forever. I'm not sure that is

Re: RFR(XXS): 8064923: [TESTBUG] jps doesn't display anything on embedded platforms and it causes some tests to fail

2015-03-18 Thread Jaroslav Bachorik
Thumbs up! On 18.3.2015 18:25, Erik Gahlin wrote: Looks good. Erik Yekaterina Kantserova skrev den 18/03/15 17:37: Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8064923 webrev: http://cr.openjdk.java.net/~ykantser/8064923/webrev.00/

Re: RFR(XXS): 8064923: [TESTBUG] jps doesn't display anything on embedded platforms and it causes some tests to fail

2015-03-18 Thread Erik Gahlin
Looks good. Erik Yekaterina Kantserova skrev den 18/03/15 17:37: Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8064923 webrev: http://cr.openjdk.java.net/~ykantser/8064923/webrev.00/ Thanks, Katja

RFR(XXS): 8064923: [TESTBUG] jps doesn't display anything on embedded platforms and it causes some tests to fail

2015-03-18 Thread Yekaterina Kantserova
Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8064923 webrev: http://cr.openjdk.java.net/~ykantser/8064923/webrev.00/ Thanks, Katja

Re: RFR(XS): 8071687: AIX port of "8039173: Propagate errors from Diagnostic Commands as exceptions in the attach framework"

2015-03-18 Thread Volker Simonis
No problem:) Thanks for the review, Volker On Tue, Mar 17, 2015 at 7:55 PM, Staffan Larsen wrote: > Looks good to me. Sorry I didn’t do those changes as well. > > /Staffan > >> On 17 mar 2015, at 18:40, Volker Simonis wrote: >> >> Hi, >> >> can I please have a review for this AIX-only change.