Erik, Jaroslav, thanks for your reviews!
// Katja
On 03/18/2015 06:25 PM, Erik Gahlin wrote:
Looks good.
Erik
Yekaterina Kantserova skrev den 18/03/15 17:37:
Hi,
Could I please have a review of this very small fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8064923
webrev:
Please, review the following change
Issue : https://bugs.openjdk.java.net/browse/JDK-8054890
Webrev: http://cr.openjdk.java.net/~jbachorik/8054890/webrev.00
This patch is about adding 2 new diagnostic commands - VM.set_flag and
JVMTI.data_dump.
VM.set_flag allows to set any writeable flag.
Jaroslav,
src/share/vm/services/diagnosticCommand.cpp
No comments
src/share/vm/services/diagnosticCommand.hpp
Why adding #include services/attachListener.hpp ?
test/serviceability/dcmd/jvmti/DataDumpDcmdTest.java
test/serviceability/dcmd/vm/SetVMFlagTest.java
I don't know the new test
On 3/12/15 11:27 PM, serguei.spit...@oracle.com wrote:
Please, review the jdk 9 fix for:
https://bugs.openjdk.java.net/browse/JDK-8067662
Open hotspot webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8067662-JVMTI-trace.1/
Thumbs up. None of these comments are critical.
On 3/13/15, 2:37 PM, Coleen Phillimore wrote:
On 3/13/15, 2:36 PM, serguei.spit...@oracle.com wrote:
Coleen,
Thank you for review and great idea to use the method name cp index!
However, this approach is going stop working if we get rid of the CP
merge in the future.
Yes, it will. I was
On 3/19/15 11:11 AM, Daniel D. Daugherty wrote:
On 3/12/15 11:27 PM, serguei.spit...@oracle.com wrote:
Please, review the jdk 9 fix for:
https://bugs.openjdk.java.net/browse/JDK-8067662
Open hotspot webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8067662-JVMTI-trace.1/
I need another reviewer for this.
Thanks,
Serguei
On 3/13/15 10:40 AM, Coleen Phillimore wrote:
Serguei,
This looks good. This works a lot harder to find the original method
than the code used to.
Thanks,
Coleen
On 3/13/15, 1:27 AM, serguei.spit...@oracle.com wrote:
Please, review the
