RFR(S, TEST) JDK-8075569: jmap test fails due to "ERROR: java.nio.file.NoSuchFileException: 2906081d-06bc-4738-a7e8-f37b8bf13658.lck

Hi Everyone, Please review small, test only fix. http://cr.openjdk.java.net/~dsamersoff/JDK-8075569/webrev.01/ Lock deleted while we are setting last modified time. Ignore error and lets the app exits -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would

Re: RFR(S, TEST) JDK-8075569: jmap test fails due to "ERROR: java.nio.file.NoSuchFileException: 2906081d-06bc-4738-a7e8-f37b8bf13658.lck

On 21/03/2015 10:50, Dmitry Samersoff wrote: Hi Everyone, Please review small, test only fix. http://cr.openjdk.java.net/~dsamersoff/JDK-8075569/webrev.01/ Lock deleted while we are setting last modified time. Ignore error and lets the app exits This looks okay to me but since it now handles

Re: RFR(S, TEST) JDK-8075569: jmap test fails due to "ERROR: java.nio.file.NoSuchFileException: 2906081d-06bc-4738-a7e8-f37b8bf13658.lck

Alan, Thank you for the review. I agree that File.exists is no longer required, but I would prefer to keep it for better readability. -Dmitry On 2015-03-21 13:57, Alan Bateman wrote: > On 21/03/2015 10:50, Dmitry Samersoff wrote: >> Hi Everyone, >> >> Please review small, test only fix. >> >> h

Re: RFR(S, TEST) JDK-8075569: jmap test fails due to "ERROR: java.nio.file.NoSuchFileException: 2906081d-06bc-4738-a7e8-f37b8bf13658.lck

On 21/03/2015 13:29, Dmitry Samersoff wrote: Alan, Thank you for the review. I agree that File.exists is no longer required, but I would prefer to keep it for better readability. -Dmitry Fair enough, either way will work.

Re: RFR 8054890: Serviceability: New diagnostic commands 'VM.set_flag' and 'JVMTI.data_dump'

Looks good! Erik Jaroslav Bachorik skrev 2015-03-19 10:59: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8054890 Webrev: http://cr.openjdk.java.net/~jbachorik/8054890/webrev.00 This patch is about adding 2 new diagnostic commands - VM.set_flag and JVMTI