A couple more comments on the draft as it stands.
I like the approach of @NotificationSupport on fields. However, the
name is not great I think. Maybe nest an @Inject annotation inside
NotificationSender, so you could write
@NotificationSender.Inject private NotificationSender sender;
?
I think
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8066679
Open hotspot webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8066679-JVMTI-cache.1/
Summary:
There can be multiple concurrent RetransformClasses calls on
different threads.
So that, the asser
Alexandar, Shura,
The dependency analysis is not up-to-date that sun.tools.jar
has been moved to jdk.jartool module in jdk9 b55. It has been
in jdk9/dev since 3/6.
I have pointed out multiple times previously that jdk.dev/sun.tools.jar
is wrong in the jdk side of change.
Below includes an ex
On 3/25/2015 10:38 AM, Alexander Kulyakhtin wrote:
Hi
Please, find the updated review for the bulk @modules change at the link below.
We have fixed the copyrights and the files mentioned in the mail from Lois.
http://cr.openjdk.java.net/~eistepan/~akulyakhtin/8075586/index.html
Thank you ve
On 23.3.2015 13:12, Jaroslav Bachorik wrote:
On 18.3.2015 23:28, Eamonn McManus wrote:
Mainly because the long term goal (beyond the scope of this JEP,
anyway) would be to get users to slowly migrate to the annotation
based M(X)Beans. Not giving them the chance to specify the service
interface v
Hi
Please, find the updated review for the bulk @modules change at the link below.
We have fixed the copyrights and the files mentioned in the mail from Lois.
http://cr.openjdk.java.net/~eistepan/~akulyakhtin/8075586/index.html
Best regards,
Alex
- Original Message -
From: lois.fol..
Serguei, thanks for the review!
// Katja
- Original Message -
From: serguei.spit...@oracle.com
To: yekaterina.kantser...@oracle.com, serviceability-dev@openjdk.java.net
Sent: Wednesday, March 25, 2015 12:35:30 PM GMT +01:00 Amsterdam / Berlin /
Bern / Rome / Stockholm / Vienna
Subject: R
Hi Katya,
It looks good.
Thanks,
Serguei
On 3/25/15 3:05 AM, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of these 2 very small fixes.
bug: https://bugs.openjdk.java.net/browse/JDK-8075818
webrev: http://cr.openjdk.java.net/~ykantser/8075818/webrev.00/
bug: https://bugs.ope
I will. Thanks for the review!
// Katja
- Original Message -
From: jaroslav.bacho...@oracle.com
To: serviceability-dev@openjdk.java.net
Sent: Wednesday, March 25, 2015 11:19:31 AM GMT +01:00 Amsterdam / Berlin /
Bern / Rome / Stockholm / Vienna
Subject: Re: RFR(XXS): 8075818: serviceabil
Hi Katja,
this looks good. Just update the copyright years before pushing. No need
to re-review.
-JB-
On 25.3.2015 11:05, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of these 2 very small fixes.
bug: https://bugs.openjdk.java.net/browse/JDK-8075818
webrev: http://cr.openj
Hi,
Could I please have a review of these 2 very small fixes.
bug: https://bugs.openjdk.java.net/browse/JDK-8075818
webrev: http://cr.openjdk.java.net/~ykantser/8075818/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-8075820
webrev: http://cr.openjdk.java.net/~ykantser/8075820/webrev.00
11 matches
Mail list logo
