Re: RFR(XS)v2: JDK-8067991 [Findbugs] SA com.sun.java.swing.ui.CommonUI some methods need final protect

2015-04-03 Thread serguei.spit...@oracle.com
Dmitry, I'm puzzled a little bit with the webrev.02: agent/src/share/classes/com/sun/java/swing/ui/CommonToolBar.java -buttonSize = new Dimension(CommonUI.buttconPrefSize); +buttonSize = new Dimension(CommonUI.getButtonPrefSize()); Why do you replace the CommonUI.buttconPrefSi

Re: RFR 8074368: ThreadMXBean.getThreadInfo() corrupts memory when called with empty array for thread ids

2015-04-03 Thread Mandy Chung
On 4/3/15 7:31 AM, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8074368 Webrev: http://cr.openjdk.java.net/~jbachorik/8074368/webrev.00 Looks okay to me. Minor comment on ThreadInfoArray.java test: You can have one single @bug l

Re: RFR(XS)v2: JDK-8067991 [Findbugs] SA com.sun.java.swing.ui.CommonUI some methods need final protect

2015-04-03 Thread Dmitry Samersoff
Everybody, Please, review updated webrev: http://cr.openjdk.java.net/~dsamersoff/JDK-8067991/webrev.02/ Fixed a compilation error that wasn't caught during incremental build. -Dmitry On 2015-04-02 15:54, Dmitry Samersoff wrote: > Everybody, > > Please review a small fix: > > The fix goes t

Unable to create hprof heap dump from core file with jmap on Oracle Solaris

2015-04-03 Thread Basil Crow
Hi all, I'm having trouble using jmap(1) to create an hprof heap dump from a core file on Oracle Solaris with version 8 of the Oracle JDK. This worked with version 7 of the Oracle JDK: $ cat Sleep.java public class Sleep { public static void main(String[] args) throws InterruptedException {

RFR 8074368: ThreadMXBean.getThreadInfo() corrupts memory when called with empty array for thread ids

2015-04-03 Thread Jaroslav Bachorik
Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8074368 Webrev: http://cr.openjdk.java.net/~jbachorik/8074368/webrev.00 Invoking ThreadMXBean.getThreadInfo(long[] ids, int maxdepth) with an empty array for 'ids' and positive number for 'maxdepth' can result

Re: RFR 8042901: Allow com.sun.management to be in a different module to java.lang.management

2015-04-03 Thread Shanliang Jiang
Mandy Chung wrote: CheckSomeMXBeanImplPackage.java line 45-50 & 58-60: should be called unconditionally since they should pass if java.management is present. The method "check" checks that an MBean implementation must be from "com.sun.management.internal", so even we look for an MXBean with