RFR(XXS): 8077611: com/sun/jdi/ConnectedVMs.java should be unquarantined

2015-04-14 Thread Yekaterina Kantserova
Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8077611 webrev: http://cr.openjdk.java.net/~ykantser/8077611/webrev.00 Thanks, Katja

Re: [ping] Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

2015-04-14 Thread Daniel Fuchs
Hi Jaroslav, Shouldn't you also wait for the blockedThread to be blocked on lockA at around line 252? (I mean - using Utils.waitForThreadState(blockedThread, State.BLOCKED)) best regards, -- daniel On 4/13/15 10:07 AM, Jaroslav Bachorik wrote: On 9.4.2015 20:11, Jaroslav Bachorik wrote:

Re: [ping] Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

2015-04-14 Thread Jaroslav Bachorik
Hi Daniel, On 14.4.2015 09:38, Daniel Fuchs wrote: Hi Jaroslav, Shouldn't you also wait for the blockedThread to be blocked on lockA at around line 252? (I mean - using Utils.waitForThreadState(blockedThread, State.BLOCKED)) Yes, nice catch. Thanks!

Re: [ping] Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

2015-04-14 Thread Daniel Fuchs
On 14/04/15 11:28, Jaroslav Bachorik wrote: Hi Daniel, On 14.4.2015 09:38, Daniel Fuchs wrote: Hi Jaroslav, Shouldn't you also wait for the blockedThread to be blocked on lockA at around line 252? (I mean - using Utils.waitForThreadState(blockedThread, State.BLOCKED)) Yes, nice catch.

Re: [ping] Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

2015-04-14 Thread Jaroslav Bachorik
On 14.4.2015 14:37, serguei.spit...@oracle.com wrote: On 4/14/15 12:38 AM, Daniel Fuchs wrote: Hi Jaroslav, Shouldn't you also wait for the blockedThread to be blocked on lockA at around line 252? (I mean - using Utils.waitForThreadState(blockedThread, State.BLOCKED)) I guess, it is about

Re: RFR 8041565: JMX ObjectName could be refactored to save memory

2015-04-14 Thread Jaroslav Bachorik
On 14.4.2015 14:56, Daniel Fuchs wrote: Hi Jaroslav, I like this change, but it does introduce an incompatibility, so it probably needs a CCC and some release notes. For instance, this test passes with the current version of ObjectName: public class StringLengthTest { final static int

Re: [ping] Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

2015-04-14 Thread serguei.spit...@oracle.com
On 4/14/15 7:44 AM, Jaroslav Bachorik wrote: On 14.4.2015 14:37, serguei.spit...@oracle.com wrote: On 4/14/15 12:38 AM, Daniel Fuchs wrote: Hi Jaroslav, Shouldn't you also wait for the blockedThread to be blocked on lockA at around line 252? (I mean - using

Re: RFR 8041565: JMX ObjectName could be refactored to save memory

2015-04-14 Thread Daniel Fuchs
Hi Jaroslav, I like this change, but it does introduce an incompatibility, so it probably needs a CCC and some release notes. For instance, this test passes with the current version of ObjectName: public class StringLengthTest { final static int smax = Short.MAX_VALUE; final static

Re: RFR 8041565: JMX ObjectName could be refactored to save memory

2015-04-14 Thread Daniel Fuchs
On 14/04/15 14:56, Daniel Fuchs wrote: With that in mind I believe you should consider throwing InternalError - or IllegalArgumentException - instead of using 'assert' statements. Actually - MalformedObjectNameException would be more appropriate. Stupid me. -- daniel

Re: [ping] Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

2015-04-14 Thread serguei.spit...@oracle.com
On 4/14/15 12:38 AM, Daniel Fuchs wrote: Hi Jaroslav, Shouldn't you also wait for the blockedThread to be blocked on lockA at around line 252? (I mean - using Utils.waitForThreadState(blockedThread, State.BLOCKED)) I guess, it is about these lines: 255