Re: JDK 9 RFR of JDK-8078334: Mark regression tests using randomness

2015-04-23 Thread Alan Bateman
On 24/04/2015 02:54, Joseph D. Darcy wrote: Hello, Any additional comments on marking with tests in question with a "randomness" keyword? Thanks, -Joe I don't object to this keyword although I should say that most of the (apparent) randomness that I've seen hasn't been because of tests usi

Re: JDK 9 RFR of JDK-8078334: Mark regression tests using randomness

2015-04-23 Thread Joseph D. Darcy
Hello, Any additional comments on marking with tests in question with a "randomness" keyword? Thanks, -Joe On 4/21/2015 7:13 PM, Joseph D. Darcy wrote: Hello, As the next step of implementing "Proposed new policies for JDK 9 regression tests: tiered testing, intermittent failures, and ra

Re: RFR: 8076473 Remove the jhat code and update makefiles

2015-04-23 Thread serguei.spit...@oracle.com
On 4/23/15 2:50 PM, Erik Joelsson wrote: No, that file is old legacy and not used anymore. It will hopefully soon go away. Ok then. Thanks, Erik! Serguei /Erik On 2015-04-23 12:52, serguei.spit...@oracle.com wrote: It looks good. A question: Do we want to get rid of the jhat in the jdk

Re: RFR: 8076473 Remove the jhat code and update makefiles

2015-04-23 Thread Erik Joelsson
No, that file is old legacy and not used anymore. It will hopefully soon go away. /Erik On 2015-04-23 12:52, serguei.spit...@oracle.com wrote: It looks good. A question: Do we want to get rid of the jhat in the jdk/closed/old-build/common/Release.gmk ? jhat.1 \ com/sun/

Re: RFR: 8076473 Remove the jhat code and update makefiles

2015-04-23 Thread serguei.spit...@oracle.com
It looks good. A question: Do we want to get rid of the jhat in the jdk/closed/old-build/common/Release.gmk ? jhat.1 \ com/sun/tools/hat \ jhat$(EXE_SUFFIX) Thanks, Serguei On 4/23/15 5:06 AM, Staffan Larsen wrote: Please review this change to remove the jhat

Re: RFR: 8078519 Can't run SA tools from a non-images build

2015-04-23 Thread Dmitry Samersoff
Staffan, Looks good for me. -Dmitry On 2015-04-23 17:51, Staffan Larsen wrote: > Here is an improved and simplified patch: > > diff --git a/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java > b/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java > --- a/agent/src/share/classes/sun/jvm

Re: RFR: 8078519 Can't run SA tools from a non-images build

2015-04-23 Thread Mandy Chung
On 04/23/2015 07:51 AM, Staffan Larsen wrote: Here is an improved and simplified patch: diff --git a/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java b/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java --- a/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java +++ b/agent/src/s

Re: RFR: 8076473 Remove the jhat code and update makefiles

2015-04-23 Thread Erik Joelsson
Looks good to me. /Erik On 2015-04-23 05:15, Alan Bateman wrote: On 23/04/2015 13:06, Staffan Larsen wrote: Please review this change to remove the jhat tool. I will not push this change until the tests have been removed (see a different review thread). JEP: https://bugs.openjdk.java.net/

Re: RFR: 8078519 Can't run SA tools from a non-images build

2015-04-23 Thread Alan Bateman
On 23/04/2015 15:51, Staffan Larsen wrote: Here is an improved and simplified patch: diff --git a/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java b/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java --- a/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java +++ b/agent/src/sh

Re: RFR: 8078519 Can't run SA tools from a non-images build

2015-04-23 Thread Staffan Larsen
Here is an improved and simplified patch: diff --git a/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java b/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java --- a/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java +++ b/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java @@ -

RFR: 8078519 Can't run SA tools from a non-images build

2015-04-23 Thread Staffan Larsen
Please see description of the problem in the bug report: https://bugs.openjdk.java.net/browse/JDK-8078519 The simple fix is included below. Thanks, /Staffan diff --git a/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java b/agent/src/sha

Re: RFR 8077953: [TEST_BUG] com/sun/management/OperatingSystemMXBean/TestTotalSwap.java Compilation failed after JDK-8077387

2015-04-23 Thread Staffan Larsen
Looks good! (assuming you ran through the tests successfully) Thanks, /Staffan > On 23 apr 2015, at 14:38, Jaroslav Bachorik > wrote: > > Please, review this JDK8 only test change > > Issue : https://bugs.openjdk.java.net/browse/JDK-8077953 > Webrev: http://cr.openjdk.java.net/~jbachorik/8077

RFR 8077953: [TEST_BUG] com/sun/management/OperatingSystemMXBean/TestTotalSwap.java Compilation failed after JDK-8077387

2015-04-23 Thread Jaroslav Bachorik
Please, review this JDK8 only test change Issue : https://bugs.openjdk.java.net/browse/JDK-8077953 Webrev: http://cr.openjdk.java.net/~jbachorik/8077953/webrev.00 Backport of https://bugs.openjdk.java.net/browse/JDK-8077387 requires testlibrary functionality not yet backported to JDK8. This pat

Re: RFR: 8076473 Remove the jhat code and update makefiles

2015-04-23 Thread Alan Bateman
On 23/04/2015 13:06, Staffan Larsen wrote: Please review this change to remove the jhat tool. I will not push this change until the tests have been removed (see a different review thread). JEP: https://bugs.openjdk.java.net/browse/JDK-8059039 bug: https://bugs.openjdk.java.net/browse/JDK-807

RFR: 8076473 Remove the jhat code and update makefiles

2015-04-23 Thread Staffan Larsen
Please review this change to remove the jhat tool. I will not push this change until the tests have been removed (see a different review thread). JEP: https://bugs.openjdk.java.net/browse/JDK-8059039 bug: https://bugs.openjdk.java.net/browse/JD