Re: Potential infinite waiting at JMXConnection#createConnection

2015-05-04 Thread Shanliang Jiang
Hi Yuji, (I reply to serviceability alias) When you create a RMI server connector, you can specify a RMIClientSocketFactory by RMI_CLIENT_SOCKET_FACTORY_ATTRIBUTE ,

Re: RFR: JDK-8077422: hprof agent: Build failed with VS2013 Update 4

2015-05-04 Thread Tim Bell
Erik: Looks good to me as well. Tim On 05/04/15 08:13, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 4 maj 2015, at 15:46, Erik Joelsson wrote: Hello, This bug has been marked as won't fix since the code it affects is going to be removed. However, until that removal happens, we

Re: RFR: JDK-8077422: hprof agent: Build failed with VS2013 Update 4

2015-05-04 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 4 maj 2015, at 15:46, Erik Joelsson wrote: > > Hello, > > This bug has been marked as won't fix since the code it affects is going to > be removed. However, until that removal happens, we can't build using VS2013 > SP4. I'm in the process of updating the com

RFR: JDK-8077422: hprof agent: Build failed with VS2013 Update 4

2015-05-04 Thread Erik Joelsson
Hello, This bug has been marked as won't fix since the code it affects is going to be removed. However, until that removal happens, we can't build using VS2013 SP4. I'm in the process of updating the compilers used internally at Oracle to that specific version and to be able to continue that w

Re: RFR 8072906: sun/management/jmxremote/bootstrap/CustomLauncherTest.java failing on embedded platform

2015-05-04 Thread serguei.spit...@oracle.com
On 5/4/15 12:23 AM, David Holmes wrote: On 4/05/2015 4:13 PM, Jaroslav Bachorik wrote: On 30.4.2015 23:08, David Holmes wrote: On 1/05/2015 12:48 AM, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8072906 Webrev: http://cr.op

Re: RFR: JDK-8079248 JDK fails with "jdk\\bin\\management_ext.dll: The specified procedure could not be found"

2015-05-04 Thread Staffan Larsen
Thanks for the reviews - the fix is now in the JPRT queue. /Staffan > On 4 maj 2015, at 11:11, Erik Joelsson wrote: > > > On 2015-05-04 10:25, Staffan Larsen wrote: >>> On 4 maj 2015, at 09:54, Magnus Ihse Bursie >>> wrote: >>> >>> 4 maj 2015 kl. 09:27 skrev David Holmes :

Re: RFR: JDK-8079248 JDK fails with "jdk\\bin\\management_ext.dll: The specified procedure could not be found"

2015-05-04 Thread Erik Joelsson
On 2015-05-04 10:25, Staffan Larsen wrote: On 4 maj 2015, at 09:54, Magnus Ihse Bursie wrote: 4 maj 2015 kl. 09:27 skrev David Holmes : Hi Staffan, Seems fine as a spot fix but I'm wondering if this shouldn't be a common option for all the dlls now we are building with VS2013? Or maybe

Re: RFR: JDK-8079248 JDK fails with "jdk\\bin\\management_ext.dll: The specified procedure could not be found"

2015-05-04 Thread Staffan Larsen
> On 4 maj 2015, at 09:54, Magnus Ihse Bursie > wrote: > > >> 4 maj 2015 kl. 09:27 skrev David Holmes : >> >> Hi Staffan, >> >> Seems fine as a spot fix but I'm wondering if this shouldn't be a common >> option for all the dlls now we are building with VS2013? > > Or maybe as a define in t

Re: RFR: JDK-8079248 JDK fails with "jdk\\bin\\management_ext.dll: The specified procedure could not be found"

2015-05-04 Thread Magnus Ihse Bursie
> 4 maj 2015 kl. 09:27 skrev David Holmes : > > Hi Staffan, > > Seems fine as a spot fix but I'm wondering if this shouldn't be a common > option for all the dlls now we are building with VS2013? Or maybe as a define in the source code before the include section for the specific source code t

Re: RFR: JDK-8079248 JDK fails with "jdk\\bin\\management_ext.dll: The specified procedure could not be found"

2015-05-04 Thread Staffan Larsen
> On 4 maj 2015, at 09:27, David Holmes wrote: > > Hi Staffan, > > Seems fine as a spot fix but I'm wondering if this shouldn't be a common > option for all the dlls now we are building with VS2013? I’ll let the build team comment on that. /Staffan > > Thanks, > David > > On 4/05/2015 4:5

Re: RFR: JDK-8079248 JDK fails with "jdk\\bin\\management_ext.dll: The specified procedure could not be found"

2015-05-04 Thread David Holmes
Hi Staffan, Seems fine as a spot fix but I'm wondering if this shouldn't be a common option for all the dlls now we are building with VS2013? Thanks, David On 4/05/2015 4:52 PM, Staffan Larsen wrote: This is a P1 bug that surfaced when changes from jdk9/dev and jdk9/hs-rt met in jdk9/hs. In

Re: RFR: JDK-8079248 JDK fails with "jdk\\bin\\management_ext.dll: The specified procedure could not be found"

2015-05-04 Thread Jaroslav Bachorik
Looks ok. -JB- On 4.5.2015 08:52, Staffan Larsen wrote: This is a P1 bug that surfaced when changes from jdk9/dev and jdk9/hs-rt met in jdk9/hs. In this case the windows compiler upgrades in jdk9/dev met changes in jdk9/hs-rt that moved a call to GetProcessMemoryInfo from management.dll to m

Re: RFR 8072906: sun/management/jmxremote/bootstrap/CustomLauncherTest.java failing on embedded platform

2015-05-04 Thread David Holmes
On 4/05/2015 4:13 PM, Jaroslav Bachorik wrote: On 30.4.2015 23:08, David Holmes wrote: On 1/05/2015 12:48 AM, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8072906 Webrev: http://cr.openjdk.java.net/~jbachorik/8072906/webrev.