Re: RFR: 8079360 AttachProviderImpl could not be instantiated

2015-05-06 Thread serguei.spit...@oracle.com
Looks good. Thanks, Serguei On 5/6/15 11:51 AM, Staffan Larsen wrote: This is another library that needs to be compiled with -DPSAPI_VERSION=1 due to the recent Windows compiler upgrade. I have also fixed a better error message that prints the underlaying exception if something like this hap

Re: Potential infinite waiting at JMXConnection#createConnection

2015-05-06 Thread KUBOTA Yuji
Hi Shanliang, Thanks you for your help! RMI_CLIENT_SOCKET_FACTORY_ATTRIBUTE is a nice workaround. However, many users believe sun.rmi.transport.tcp.responseTimeout to specify the timeout, e.g. the second flush() of TCPChannel#createConnection [2]. In really, the first flush()[3] is not affected

Re: RFR(M): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-06 Thread Derek White
Hi Dmitry, Staffan, Lots of good comments here. On the topic of what list should be printed out, I think we should focus on objects waiting to be finalized - e.g. the contents of the ReferenceQueue. It's more of a pain to walk the ReferenceQueue, but you could add a summerizeQueue(TreeMap) me

Re: RFR: 8079360 AttachProviderImpl could not be instantiated

2015-05-06 Thread Dmitry Samersoff
Staffan, Looks good for me. -Dmitry On 2015-05-06 21:51, Staffan Larsen wrote: > This is another library that needs to be compiled with -DPSAPI_VERSION=1 > due to the recent Windows compiler upgrade. > > I have also fixed a better error message that prints the underlaying > exception if somethi

Re: PING Re: RFR: 8078521: AARCH64: Add AArch64 SA support

2015-05-06 Thread Dmitry Samersoff
Andrew, I'm looking into it and come back tomorrow. (not a reviewer but current SA owner) -Dmitry On 2015-05-06 17:36, Andrew Haley wrote: > On 04/29/2015 08:42 AM, Andrew Haley wrote: >> >> http://cr.openjdk.java.net/~aph/8078521-2/ > > Any news on this? It shouldn't be controversial at this

Re: PING Re: RFR: 8078521: AARCH64: Add AArch64 SA support

2015-05-06 Thread Dean Long
I added hotspot-...@openjdk.java.net again. It looks reasonable to me, but I'm not a Reviewer. dl On 5/6/2015 7:36 AM, Andrew Haley wrote: On 04/29/2015 08:42 AM, Andrew Haley wrote: http://cr.openjdk.java.net/~aph/8078521-2/ Any news on this? It shouldn't be controversial at this point. T

RFR: 8079360 AttachProviderImpl could not be instantiated

2015-05-06 Thread Staffan Larsen
This is another library that needs to be compiled with -DPSAPI_VERSION=1 due to the recent Windows compiler upgrade. I have also fixed a better error message that prints the underlaying exception if something like this happens again. webrev: http://cr.openjdk.java.net/~sla/8079360/webrev.00/

Re: RFR(M): 8078896: Add @modules as needed to the jdk_svc tests

2015-05-06 Thread Mandy Chung
On 05/06/2015 04:21 AM, Yekaterina Kantserova wrote: The new webrev can be found here: http://cr.openjdk.java.net/~ykantser/8078896/webrev.02/ Looks good. About the test selection, one typical aspect of svc tests is to run a j* tool in a child process (e.g. jinfo, jstack, jstat, jstatd,

RFR(XS): 8079510: AIX: fix build after '8042901: Allow com.sun.management to be in a different module...'

2015-05-06 Thread Volker Simonis
Hi, can somebody please review this trivial AIX-only change which fixes an AIX build error: http://cr.openjdk.java.net/~simonis/webrevs/2015/8079510/ https://bugs.openjdk.java.net/browse/JDK-8079510 Here are the details: Change '8042901: Allow com.sun.management to be in a different module to j

PING Re: RFR: 8078521: AARCH64: Add AArch64 SA support

2015-05-06 Thread Andrew Haley
On 04/29/2015 08:42 AM, Andrew Haley wrote: > > http://cr.openjdk.java.net/~aph/8078521-2/ Any news on this? It shouldn't be controversial at this point. Thanks, Andrew.

Re: RFR(M): 8078896: Add @modules as needed to the jdk_svc tests

2015-05-06 Thread Yekaterina Kantserova
Mandy, Thanks fro your review! Please see my comment inlined. On 05/05/2015 11:00 PM, Mandy Chung wrote: com.sun.management has been moved to jdk.management module. The patch for JDK-8042901 is just integrated in jdk9/dev today. Most, if not all, test/com/sun/management tests need updates t

Re: Potential infinite waiting at JMXConnection#createConnection

2015-05-06 Thread KUBOTA Yuji
2015-05-06 19:48 GMT+09:00 Shanliang Jiang : > To reproduce the bug, I was thinking to use > RMI_SERVER_SOCKET_FACTORY_ATTRIBUTE to specify a user socket server, which > will not response any client connection request, I did not yet test this > solution. Thanks, I will try to reproduce with th

Re: Potential infinite waiting at JMXConnection#createConnection

2015-05-06 Thread Shanliang Jiang
KUBOTA Yuji wrote: Hi Shanliang, Many thanks for your help! I do not have any role yet. So I can not create a new bug at JBS. It's a reason why I submitted a mail with my patch at first. This issue is caused by a rare network problem during the flush() [3] . I got this infinite loop only o

Re: Potential infinite waiting at JMXConnection#createConnection

2015-05-06 Thread KUBOTA Yuji
Hi Shanliang, Many thanks for your help! I do not have any role yet. So I can not create a new bug at JBS. It's a reason why I submitted a mail with my patch at first. This issue is caused by a rare network problem during the flush() [3] . I got this infinite loop only once. So I will try to wri

Re: Potential infinite waiting at JMXConnection#createConnection

2015-05-06 Thread Shanliang Jiang
Hi Yuji, I think better at first to create a bug at: https://bugs.openjdk.java.net/secure/Dashboard.jspa It looks like an issue for me, it must be possible to have a test to reproduce the issue. It is helpful to attach the test and present your solution in the bug. I can help if you need

Re: Potential infinite waiting at JMXConnection#createConnection

2015-05-06 Thread KUBOTA Yuji
My apologies for re-post, I forgot to register serviceability-dev before the last post. Hi Shanliang, Thanks you for your help! RMI_CLIENT_SOCKET_FACTORY_ATTRIBUTE is a nice workaround. However, many users believe sun.rmi.transport.tcp.responseTimeout to specify the timeout, e.g. the second flu

Re: RFR(XS): 8076998: BadHandshakeTest.java fails due to warnings in output

2015-05-06 Thread Yekaterina Kantserova
Thanks Serguei! On 05/06/2015 12:48 AM, serguei.spit...@oracle.com wrote: Looks good. Thanks, Serguei On 5/5/15 6:24 AM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8076998 webrev: http://cr.openjdk.java.net/~ykant

Re: RFR(M): 8078896: Add @modules as needed to the jdk_svc tests

2015-05-06 Thread Alan Bateman
On 05/05/2015 22:00, Mandy Chung wrote: : About the test selection, one typical aspect of svc tests is to run a j* tool in a child process (e.g. jinfo, jstack, jstat, jstatd,jcmd, jps etc that are in jdk.jcmd module). I would expect all test/sun/tools/jcmd tests should have @modules jdk.jc