On 13/05/2015 9:46 PM, Jaroslav Bachorik wrote:
On 1.5.2015 21:55, Martin Buchholz wrote:
On Thu, Apr 30, 2015 at 11:27 AM, Jaroslav Bachorik
mailto:jaroslav.bacho...@oracle.com>>
wrote:
On 30.4.2015 19:18, Martin Buchholz wrote:
Tests that sleep can almost always be better writt
Hi Dmitry,
Some review comments below...
On 5/12/15 1:10 PM, Dmitry Samersoff wrote:
Everybody,
Updated version:
http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.03/
Now it iterates over queue and output result sorted by number of instances.
FinalReference.java
- Update copyright
Hi Peter,
I don't have smoking gun evidence that your change introduces a bug, but
I have some concerns...
On 5/12/15 6:05 PM, Peter Levart wrote:
Hi Dmitry,
You iterate the queue then, not the unfinalized list. That's more logical.
Holding the queue's lock may pause reference handler and f
With perm gen going away (and being replaced by metaspace) in JDK 8, it
makes sense that the counter
sun.gc.policy.generations should be "2", rather than "3". However, in JDK 8
that counter still says 3.
As I understand, the intention was that this counter would allow you to
(for example) know the
David has given you an approval; feel free to ignore me!
I tried running the test against jdk9, but it timed out!
It's common for users to introduce parallelism in classloaders or
jar-loaders (we do this at google) which may cause arbitrary thread
fluctuations. That makes this particular API rat
On 13.5.2015 19:40, Martin Buchholz wrote:
toString()should never return null, I think.
It doesn't matter much here. The test would fail with an NPE and it
would be right to do so. None of the suppliers should ever return null.
52 @Override
53 public String toString()
toString() should never return null, I think.
52 @Override 53 public String toString() { 54
T resolved = val.get(); 55 return resolved != null
? resolved.toString() : null; 56 }
I expected methods like waitForCondition to include a timeout with
fa
Please, review the following change
Issue : https://bugs.openjdk.java.net/browse/JDK-8075926
Webrev: http://cr.openjdk.java.net/~jbachorik/8075926/webrev.00
The sun.management.JMXConnectorServer.. perf counters are
not updated when the remote management agent is stopped.
The perf counters sho
On 1.5.2015 21:55, Martin Buchholz wrote:
On Thu, Apr 30, 2015 at 11:27 AM, Jaroslav Bachorik
mailto:jaroslav.bacho...@oracle.com>> wrote:
On 30.4.2015 19:18, Martin Buchholz wrote:
Tests that sleep can almost always be better written some other way.
In this case, I would
