[9] RFR (M) 8054386: Allow Java debugging when CDS is enabled

Hi, Please review the following changes for allowing java debugging when CDS is enabled. Webrev: http://cr.openjdk.java.net/~cjplummer/8054386/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8054386 The VM changes are simple. I removed the chec

Re: RFR 8075926: Add a sun.management.JMXConnectorServer perf counter to track its state

Looks good! Thanks, /Staffan > On 18 maj 2015, at 19:23, Jaroslav Bachorik > wrote: > > On 18.5.2015 10:41, Staffan Larsen wrote: >> >>> On 18 maj 2015, at 10:25, Jaroslav Bachorik >>> wrote: >>> >>> On 18.5.2015 10:21, Staffan Larsen wrote: Looks good, but why is the reverseBytes nee

Re: RFR[ 9u-dev] JDK-8075773 - jps running as root fails with 7u75, works fine with 7u72

Cheleswer, This review is going to require another detailed code path analysis to see what the root user would be exposed to with this policy by-pass. Short version of what I'm worried about: The root user is potentially accessing the perf-data directory and/or perf-data files that it d

Re: RFR[ 9u-dev] JDK-8075773 - jps running as root fails with 7u75, works fine with 7u72

Just for the record... Fixing a critical typo below... On 5/14/15 10:00 AM, Daniel D. Daugherty wrote: On 5/14/15 3:34 AM, cheleswer sahu wrote: Hi, Please review the code changes for https://bugs.openjdk.java.net/browse/JDK-8075773. I have built and tested JDK9 with fix successfully. As I

Re: RFR 8078143: java/lang/management/ThreadMXBean/AllThreadIds.java fails intermittently

On Sat, May 16, 2015 at 2:18 AM, Jaroslav Bachorik < jaroslav.bacho...@oracle.com> wrote: > On 15.5.2015 22:59, Martin Buchholz wrote: > >> >> Consider creating a private thread group just for the test and >> restricting the count assertions to just threads in that thread group - >> that should be

Re: RFR: 8080538 hprof does not work well with multiple agents on non-Solaris platforms

Pushed to jdk9 dev. On Mon, May 18, 2015 at 1:13 AM, Staffan Larsen wrote: > This looks good, but given that hprof is going away [1] I’m not sure it’s > worth the time to fix it. Anyway, I’m ok with the fix. > > Thanks, > /Staffan > > [1] https://bugs.openjdk.java.net/browse/JDK-8046661 > > > On

Re: RFR 8075926: Add a sun.management.JMXConnectorServer perf counter to track its state

On 18.5.2015 10:41, Staffan Larsen wrote: On 18 maj 2015, at 10:25, Jaroslav Bachorik wrote: On 18.5.2015 10:21, Staffan Larsen wrote: Looks good, but why is the reverseBytes needed? 60 this.bb.asLongBuffer().put(Long.reverseBytes(l)); For some reason Perf.createLong(...) wil

Re: RFR (XS) 8079644: memory stomping error with ResourceManagement and TestAgentStress.java

Thanks a lot, Staffan! Serguei On 5/18/15 12:24 AM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 15 maj 2015, at 02:15, serguei.spit...@oracle.com wrote: Please, review the jdk 9 fix for: https://bugs.openjdk.java.net/browse/JDK-8079644 9 hotspot webrev: http://cr.openjdk.java.n

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

Everyone, Please review updated version of the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.07/ Most important part of the fix provided by Peter Levart, so all credentials belongs to him. -Dmitry On 2015-05-16 15:48, Peter Levart wrote: > > > On 05/16/2015 02:38 PM, Peter L

Re: RFR[ 9u-dev] JDK-8075773 - jps running as root fails with 7u75, works fine with 7u72

Cheleswer, 1. perfMemory_linux.cpp:222 missed space in !=0) 2. We have couple of other perfMemory_*.cpp files that have to be updated as well. -Dmitry On 2015-05-18 12:59, cheleswer sahu wrote: > Hi, > I have fixed the code and tested. It's working fine. Please review the > changes. > Web revie

Re: RFR[ 9u-dev] JDK-8075773 - jps running as root fails with 7u75, works fine with 7u72

Hi, I have fixed the code and tested. It's working fine. Please review the changes. Web review link: http://cr.openjdk.java.net/~dbuck/8075773/webrev.02/ Regards, Cheleswer On 5/15/2015 12:26 PM, cheleswer sahu wrote: Dear Dan & Dmitry, Thanks for pointing out the security vulnerability in th

Re: RFR 8075926: Add a sun.management.JMXConnectorServer perf counter to track its state

On 18.5.2015 10:41, Staffan Larsen wrote: On 18 maj 2015, at 10:25, Jaroslav Bachorik wrote: On 18.5.2015 10:21, Staffan Larsen wrote: Looks good, but why is the reverseBytes needed? 60 this.bb.asLongBuffer().put(Long.reverseBytes(l)); For some reason Perf.createLong(...) wil

Re: RFR 8075926: Add a sun.management.JMXConnectorServer perf counter to track its state

> On 18 maj 2015, at 10:25, Jaroslav Bachorik > wrote: > > On 18.5.2015 10:21, Staffan Larsen wrote: >> Looks good, but why is the reverseBytes needed? >> >> 60 this.bb.asLongBuffer().put(Long.reverseBytes(l)); > > For some reason Perf.createLong(...) will create bytebuffer with t

Re: RFR 8075926: Add a sun.management.JMXConnectorServer perf counter to track its state

On 18.5.2015 10:21, Staffan Larsen wrote: Looks good, but why is the reverseBytes needed? 60 this.bb.asLongBuffer().put(Long.reverseBytes(l)); For some reason Perf.createLong(...) will create bytebuffer with the HILO byte order reversed when compared to how long is usually represe

Re: PerfData counter: sun.gc.policy.generations in JDK 8

Looks like a good patch to me. /Staffan > On 14 maj 2015, at 18:12, Srinivas Ramakrishna wrote: > > https://bugs.openjdk.java.net/browse/JDK-8080345 > > > > > On Wed, May 13, 2015 at 1:08 PM, Srinivas Ramakrishna

Re: RFR 8075926: Add a sun.management.JMXConnectorServer perf counter to track its state

Looks good, but why is the reverseBytes needed? 60 this.bb.asLongBuffer().put(Long.reverseBytes(l)); Thanks, /Staffan > On 13 maj 2015, at 17:39, Jaroslav Bachorik > wrote: > > Please, review the following change > > Issue : https://bugs.openjdk.java.net/browse/JDK-8075926 > Webr

Re: RFR: 8080538 hprof does not work well with multiple agents on non-Solaris platforms

This looks good, but given that hprof is going away [1] I’m not sure it’s worth the time to fix it. Anyway, I’m ok with the fix. Thanks, /Staffan [1] https://bugs.openjdk.java.net/browse/JDK-8046661 > On 16 maj 2015, at 01:12, Jeremy Manson

Re: RFR (XS) 8079644: memory stomping error with ResourceManagement and TestAgentStress.java

Looks good! Thanks, /Staffan > On 15 maj 2015, at 02:15, serguei.spit...@oracle.com wrote: > > Please, review the jdk 9 fix for: > https://bugs.openjdk.java.net/browse/JDK-8079644 > > > 9 hotspot webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8079644-JVMTI-memstomp.1 > >