Re: RFR(M, v10): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-06-01 Thread Staffan Larsen
Dmitry, Instead of hardcoding the field offsets, you can use InstanceKlass::find_field and fieldDescriptor::offset to find the offset at runtime. Thanks, /Staffan On 31 maj 2015, at 13:43, Dmitry Samersoff dmitry.samers...@oracle.com wrote: Everyone, Please take a look at new version

Re: RFR(S): 8081037: serviceability/sa/ tests time out on Windows

2015-06-01 Thread Magnus Ihse Bursie
On 2015-05-28 16:45, Yekaterina Kantserova wrote: Hi, due to https://bugs.openjdk.java.net/browse/JDK-8081381 I wasn't able to push this fix. The problem is LingeredApp.java contains JDK 9 feature java.lang.Process.getPid() but the test library is compiled with JDK 8 today. This issue is not

Re: PerfData counter: sun.gc.policy.generations in JDK 8

2015-06-01 Thread Srinivas Ramakrishna
Thanks for the review of the patch for 8-dev (from the ticket), Staffan. Sorry for the delay in getting the official webrev out -- it took me a while to first get set up with an hs9 repo (thanks Jon!) and then get my openjdk credentials updated (thanks Mark!). Here's the webrev against hs9 for