RFR(XXS): 8131035: [TESTBUG] sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java needs to enable UsePerfData

2015-07-13 Thread Yekaterina Kantserova
Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8131035 webrev: http://cr.openjdk.java.net/~ykantser/8131035/webrev.00 Thanks, Katja

Re: RFR(XXS): 8131035: [TESTBUG] sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java needs to enable UsePerfData

2015-07-13 Thread Jaroslav Bachorik
Looks good! (btw, removing the 'author' tag was intentional?) -JB- On 13.7.2015 15:40, Yekaterina Kantserova wrote: Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8131035 webrev: http://cr.openjdk.java.net/~ykantser/8131035/webrev.00 T

Re: RFR(XXS): 8131035: [TESTBUG] sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java needs to enable UsePerfData

2015-07-13 Thread Yekaterina Kantserova
Jaroslav, Thanks for the review! Yes, removing the 'author' tag was intentional. My understanding has been it's good to avoid 'author' tag. // Katja On 07/13/2015 03:51 PM, Jaroslav Bachorik wrote: Looks good! (btw, removing the 'author' tag was intentional?) -JB- On 13.7.2015 15:40, Y

Re: RFR(XXS): 8131035: [TESTBUG] sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java needs to enable UsePerfData

2015-07-13 Thread David Holmes
Ship it! :) Thanks, David On 13/07/2015 11:40 PM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8131035 webrev: http://cr.openjdk.java.net/~ykantser/8131035/webrev.00 Thanks, Katja