Hello,
Yes, my general guidance is to make sure flaky tests are marked as
"intermittent" in the test itself. This lets someone running the test
easily check if the test is known to be unreliable *in that state of the
sources*.
There is a upfront overhead to collecting information about the c
Serguei,
Thank you for review.
> The following fragment has the same invariant for both branches:
fixed. (webrev updated in-place, diff to webrev.06.old is attached)
> One more suggestion would be to refactor the if (_optreset) { ... }
> with a cal to a new method optReset().
I would prefer to
Dmitry,
Thanks for new webrev!
A couple of comments on
hotspot_webrev/agent/src/share/classes/sun/jvm/hotspot/SAGetopt.java
The following fragment has the same invariant for both branches:
136 ch = carg.charAt(_optopt);
137 }
138 else {
139 ch = ca
Serguei,
Sorry for typeo
new webrev:
http://cr.openjdk.java.net/~dsamersoff/JDK-8059038/webrev.06
-Dmitry
On 2015-07-17 16:28, serguei.spit...@oracle.com wrote:
> On 7/17/15 6:21 AM, Dmitry Samersoff wrote:
>> Serguei,
>>
>> new webrev:
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8059038/
Hi Katja,
Looks ok to me too.
It has been a relatively manual process and I'm not aware of a
mechanism how to sync test-key-bug. What I can do is to mark bugs I
went through with for example 'key-intermittent' label to distinguish
them form the new ones.
That's another additional label, and
On 17/07/2015 14:59, Alexander Kulyakhtin wrote:
Jaroslav,
Ok, I'm going to create a new low-severity issue to replace /../.. with
external.lib.roots property throughout the hotspot repo.
The original issue, as the development team pointed out in the comments, is
likely to be caused by the
Hi Alexander,
Looks ok to me with same remark as Jaroslav.
Last failure was 10th of July in Comp baseline. Let's hope it fixes it.
Olivier.
On 17/07/2015 13:13, Alexander Kulyakhtin wrote:
Hi,
Can the changes below be approven?
Although they are not strictly necessary, it is better to use
Jaroslav,
Thank you for the review!
It has been a relatively manual process and I'm not aware of a mechanism
how to sync test-key-bug. What I can do is to mark bugs I went through
with for example 'key-intermittent' label to distinguish them form the
new ones.
Are there other suggestions?
On 7/17/15 6:21 AM, Dmitry Samersoff wrote:
Serguei,
new webrev:
http://cr.openjdk.java.net/~dsamersoff/JDK-8059038/webrev.05
The webrev is the same.
I do not see the changes you claim below.
Could you, please, generate a webrev with another version number?
Thanks,
Serguei
diff to webrev
Serguei,
new webrev:
http://cr.openjdk.java.net/~dsamersoff/JDK-8059038/webrev.05
diff to webrev.05.old attached
please see also below.
On 2015-07-17 13:46, serguei.spit...@oracle.com wrote:
> Dmitry,
>
> Thanks for the diff, it helps!
>
> hotspot_webrev/agent/src/share/classes/sun/jvm/hotsp
Looks good.
Is there any way to check that all the issues from the JBS query
mentioned in JDK-8075658 are addressed?
-JB-
On 17.7.2015 14:47, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8075658
webrev: http://cr.o
Jaroslav,
Ok, I'm going to create a new low-severity issue to replace /../.. with
external.lib.roots property throughout the hotspot repo.
The original issue, as the development team pointed out in the comments, is
likely to be caused by the concurrent running of jtreg tests and will remain
op
Hi,
Could I please have a review of this fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8075658
webrev: http://cr.openjdk.java.net/~ykantser/8075658/webrev.00
Thanks,
Katja
I'm OK with this change.
However, I think it would be better to open a new issue for the code
cleanup and not use the nightly-failure related one - especially since
the change would not be really fixing the failure.
Thanks,
-JB-
On 17.7.2015 13:13, Alexander Kulyakhtin wrote:
Hi,
Can the c
Thanks Jaroslav!
// Katja
On 07/17/2015 02:01 PM, Jaroslav Bachorik wrote:
Looks good!
-JB-
On 17.7.2015 13:59, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this small fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8037957
webrev: http://cr.openjdk.java.net/~ykantse
Looks good!
-JB-
On 17.7.2015 13:59, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this small fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8037957
webrev: http://cr.openjdk.java.net/~ykantser/8037957/webrev.00
Thanks,
Katja
Hi,
Could I please have a review of this small fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8037957
webrev: http://cr.openjdk.java.net/~ykantser/8037957/webrev.00
Thanks,
Katja
Hi,
Can the changes below be approven?
Although they are not strictly necessary, it is better to use
external.lib.roots property instead of specifying too many upper-level
directories, to take advantage of the latest jtreg version.
The issue itself has not been observed with the latest JDK9 b
Dmitry,
Thanks for the diff, it helps!
hotspot_webrev/agent/src/share/classes/sun/jvm/hotspot/SAGetopt.java
Uninitialized local definition:
105 char ch;
Unneded second initialization at 111:
104 String carg = _argv[_optind];
111 carg = _argv[_optind];
It is no
Serguei,
Previous webrev is:
http://cr.openjdk.java.net/~dsamersoff/JDK-8059038/webrev.05.old
Latest webrev is:
http://cr.openjdk.java.net/~dsamersoff/JDK-8059038/webrev.05
Diff between webrev.05.old and webrev.05 attached
-Dmitry
On 2015-07-17 01:00, serguei.spit...@oracle.com wrote:
> Hi Dmi
20 matches
Mail list logo
