Re: RFR (XS): 6661889: thread id on Linux is inconsistent in error and log outputs

2015-07-29 Thread Jeremy Manson
Thanks, folks! Jeremy On Wed, Jul 29, 2015 at 8:03 PM, David Holmes wrote: > On 30/07/2015 9:07 AM, Vladimir Kozlov wrote: > >> Finally after 7 years, since I filed this bug, it will be fixed :) >> > > I hope it now does what you wanted :) > > On its way. > > Thanks, > David > > > Looks good.

Re: RFR: JDK-8130527: serviceability tests fails with Can't attach to process

2015-07-29 Thread David Holmes
On 30/07/2015 12:29 AM, Alexander Kulyakhtin wrote: Hi, Could you, please, review the following small test-only fix: CR: JDK-8130527 "Serviceability tests fails with Can't attach to process." (the CR was submitted as confidential for other reasons, all changes are in the public domain) Webrev:

Re: RFR (XS): 6661889: thread id on Linux is inconsistent in error and log outputs

2015-07-29 Thread David Holmes
On 30/07/2015 9:07 AM, Vladimir Kozlov wrote: Finally after 7 years, since I filed this bug, it will be fixed :) I hope it now does what you wanted :) On its way. Thanks, David Looks good. Thanks, Vladimir On 7/29/15 3:31 PM, David Holmes wrote: Hi Jeremy, On 30/07/2015 6:34 AM, Jeremy

Re: RFR (XS): 6661889: thread id on Linux is inconsistent in error and log outputs

2015-07-29 Thread Vladimir Kozlov
Finally after 7 years, since I filed this bug, it will be fixed :) Looks good. Thanks, Vladimir On 7/29/15 3:31 PM, David Holmes wrote: Hi Jeremy, On 30/07/2015 6:34 AM, Jeremy Manson wrote: David, can you review/sponsor this, per our conversation of last week? Yes I can sponsor and it is

Re: RFR (XS): 6661889: thread id on Linux is inconsistent in error and log outputs

2015-07-29 Thread David Holmes
Hi Jeremy, On 30/07/2015 6:34 AM, Jeremy Manson wrote: David, can you review/sponsor this, per our conversation of last week? Yes I can sponsor and it is also Reviewed. But I'd like a second review from someone else. Thanks, David It fixes an issue where, on Linux, some of the Hotspot logg

RFR (XS): 6661889: thread id on Linux is inconsistent in error and log outputs

2015-07-29 Thread Jeremy Manson
David, can you review/sponsor this, per our conversation of last week? It fixes an issue where, on Linux, some of the Hotspot logging output identifies threads by pthread_id, and some of it identifies threads by kernel-level TID. This happened because Hotspot calls into two different APIs that pr

Re: RFR: JDK-8130527: serviceability tests fails with Can't attach to process

2015-07-29 Thread Jaroslav Bachorik
Looks good! -JB- On 29.7.2015 16:29, Alexander Kulyakhtin wrote: Hi, Could you, please, review the following small test-only fix: CR: JDK-8130527 "Serviceability tests fails with Can't attach to process." (the CR was submitted as confidential for other reasons, all changes are in the public

RFR: JDK-8130527: serviceability tests fails with Can't attach to process

2015-07-29 Thread Alexander Kulyakhtin
Hi, Could you, please, review the following small test-only fix: CR: JDK-8130527 "Serviceability tests fails with Can't attach to process." (the CR was submitted as confidential for other reasons, all changes are in the public domain) Webrev: http://cr.openjdk.java.net/~akulyakh/8130527/index.h