Good to go!
-JB-
On 31.7.2015 18:44, olivier.lagn...@oracle.com wrote:
Thanks Jaroslav and Serguey for the comments for first pass of review.
I have fixed the patch following your comments.
Please find the 2nd version here :
webrev: http://cr.openjdk.java.net/~olagneau/8131784/webrev.01/
Tha
Looks good.
Thanks,
Serguei
On 7/31/15 9:44 AM, olivier.lagn...@oracle.com wrote:
Thanks Jaroslav and Serguey for the comments for first pass of review.
I have fixed the patch following your comments.
Please find the 2nd version here :
webrev: http://cr.openjdk.java.net/~olagneau/8131784/webr
Hi Olivier,
Ok, reviewed.
Thank you for the update!
Serguei
On 7/31/15 9:21 AM, olivier.lagn...@oracle.com wrote:
Hi Serguey,
Thanks for reviewing. Please see comments inlined.
On 31/07/2015 01:50, serguei.spit...@oracle.com wrote:
Hi Olivier,
I agree with the comments from Jaroslav.
A cou
Thanks Jaroslav and Serguey for the comments for first pass of review.
I have fixed the patch following your comments.
Please find the 2nd version here :
webrev: http://cr.openjdk.java.net/~olagneau/8131784/webrev.01/
Thanks,
Olivier.
On 30/07/2015 18:55, olivier.lagn...@oracle.com wrote:
Hi,
Hi Serguey,
Thanks for reviewing. Please see comments inlined.
On 31/07/2015 01:50, serguei.spit...@oracle.com wrote:
Hi Olivier,
I agree with the comments from Jaroslav.
A couple of minor comments.
+ if ( exitCode != 0 ) {
Unneeded extra spaces
Ok. fixed.
+ } catch (InterruptedException
Hi Jaroslav,
Thanks for reviewing this fix. Comments inlined.
Olivier.
On 30/07/2015 19:13, Jaroslav Bachorik wrote:
Hi Olivier,
On 30.7.2015 18:55, olivier.lagn...@oracle.com wrote:
Hi,
Could you please review this fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8131784
webrev: http://c
On 31.7.2015 15:03, Daniel Fuchs wrote:
Hi Jaroslav,
Thanks for the ping, I hadn't realized you were waiting :-)
Since this is limited to complex composite attribute names
I believe it is the right thing. However - it would be good
to verify (maybe you already did it?) that it passes the JCK.
Hi Jaroslav,
Thanks for the ping, I hadn't realized you were waiting :-)
Since this is limited to complex composite attribute names
I believe it is the right thing. However - it would be good
to verify (maybe you already did it?) that it passes the JCK.
One small suggestion for the SimpleIntros
The fix looks good to me.
Nice that it does not fail in 1000 runs.
Thanks,
Serguei
On 7/31/15 4:55 AM, Jaroslav Bachorik wrote:
Could someone, please, take a look at this?
Thanks,
-JB-
On 9.7.2015 18:45, Jaroslav Bachorik wrote:
Please, review the following test change
Issue : https://bugs
On 19.6.2015 18:20, Jaroslav Bachorik wrote:
On 19.6.2015 15:50, Daniel Fuchs wrote:
Hi guys,
I believe there's a difference between Attribute names, and navigation
into complex attributes.
At the MBean level attribute names are case sensitive.
At Attribute level (= within an attribute) I beli
Could someone, please, take a look at this?
Thanks,
-JB-
On 9.7.2015 18:45, Jaroslav Bachorik wrote:
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8129976
Webrev: http://cr.openjdk.java.net/~jbachorik/8129976/webrev.00
The test, as it is now, most
11 matches
Mail list logo
