Hi Jaroslav,
379 * This field encodes _domain_pattern, _property_list_pattern and 380
* _property_value_pattern booleans.
If I'm not mistaken it also encodes the domain length.
1072 if ((l & FLAG_MASK) > 0 ) {
Although it is not expected that 'l' could be negative, it might be
better to wri
I would like to suggest some cosmetic changes. The hex constants could
have underscores, for example 0x8000_. The FLAG_MASK constant
could be expressed as the OR of the three flags rather than as a
literal, and the DOMAIN_LENGTH_MASK could be ~FLAG_MASK. In
setDomainLength, the parameter name l
Hi,
reviving this review.
On 14.4.2015 16:58, Jaroslav Bachorik wrote:
On 14.4.2015 14:56, Daniel Fuchs wrote:
Hi Jaroslav,
I like this change, but it does introduce an incompatibility,
so it probably needs a CCC and some release notes.
For instance, this test passes with the current version
Hi,
Sorry for being away for so long.
If memory serves me right then the current AllocObjectInNewTLAB JFR event was
written as a way to quickly get some allocation profiling information with a
minimum of VM changes. It probably also carried over to Hotspot from JRockit. I
agree that we can and
On 4.8.2015 09:13, David Holmes wrote:
On 4/08/2015 5:10 PM, Jaroslav Bachorik wrote:
Hi David,
On 4.8.2015 02:25, David Holmes wrote:
On 4/08/2015 1:31 AM, Jaroslav Bachorik wrote:
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8085919
Webrev: http
On 4/08/2015 5:10 PM, Jaroslav Bachorik wrote:
Hi David,
On 4.8.2015 02:25, David Holmes wrote:
On 4/08/2015 1:31 AM, Jaroslav Bachorik wrote:
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8085919
Webrev: http://cr.openjdk.java.net/~jbachorik/808591
Hi David,
On 4.8.2015 02:25, David Holmes wrote:
On 4/08/2015 1:31 AM, Jaroslav Bachorik wrote:
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8085919
Webrev: http://cr.openjdk.java.net/~jbachorik/8085919/webrev.00
The test fails on embedded machines
