Re: RFR 8041565: JMX ObjectName could be refactored to save memory

2015-08-05 Thread Eamonn McManus
That makes sense to me. I think the phrase could even be as vague as "or the name exceeds one of the implementation's limits" without saying what those limits might be. That would leave having reasonable limits as a quality-of-implementation issue, as it should be. The acid test is whether we would

Re: RFR 8041565: JMX ObjectName could be refactored to save memory

2015-08-05 Thread Stuart Marks
On 8/5/15 8:02 AM, Jaroslav Bachorik wrote: On 5.8.2015 16:53, Eamonn McManus wrote: I would remove the spec changes about the limit on the domain length, which are a property of this particular implementation. It's perfectly reasonable to blow up if the domain length is > 536,870,911, but there

Re: JDK 9 RFR of JDK-8133060: Problem list BasicLauncherTest until fix for JDK-8132648 propagates

2015-08-05 Thread Dmitry Samersoff
Joe, > +sun/tools/jhsdb/BasicLauncherTest.java macosx-all It also failing on windows-i586 so please add generic-all (Fixed in hs-rt as well) -Dmitry On 2015-08-05 19:56, joe darcy wrote: > Hello, > > With the most recent integration of HotSpot into dev, we started seeing > te

JDK 9 RFR of JDK-8133060: Problem list BasicLauncherTest until fix for JDK-8132648 propagates

2015-08-05 Thread joe darcy
Hello, With the most recent integration of HotSpot into dev, we started seeing test failures of sun/tools/jhsdb/BasicLauncherTest.java The underlying problem has been fixed by JDK-8132648 in hs-rt, but until that fix propagates, the test should be problem listed in dev: diff -r 9bce83

Re: RFR 8041565: JMX ObjectName could be refactored to save memory

2015-08-05 Thread Eamonn McManus
That makes me sad. The limit is clearly a detail of this particular implementation and should not be enshrined in the spec. Éamonn 2015-08-05 8:02 GMT-07:00 Jaroslav Bachorik : > On 5.8.2015 16:53, Eamonn McManus wrote: >> >> I would remove the spec changes about the limit on the domain length, >

Re: RFR 8041565: JMX ObjectName could be refactored to save memory

2015-08-05 Thread Jaroslav Bachorik
On 5.8.2015 16:53, Eamonn McManus wrote: I would remove the spec changes about the limit on the domain length, which are a property of this particular implementation. It's perfectly reasonable to blow up if the domain length is > 536,870,911, but there's no reason for it to be in the spec. Well

Re: RFR 8041565: JMX ObjectName could be refactored to save memory

2015-08-05 Thread Eamonn McManus
I would remove the spec changes about the limit on the domain length, which are a property of this particular implementation. It's perfectly reasonable to blow up if the domain length is > 536,870,911, but there's no reason for it to be in the spec. Éamonn 2015-08-05 4:48 GMT-07:00 Jaroslav Bacho

Re: RFR 8085919: OperatingSystemMXBean/TestTotalSwap.java failure : Total Swap Space figures mismatch

2015-08-05 Thread Daniel D. Daugherty
On 8/4/15 1:22 AM, Jaroslav Bachorik wrote: On 4.8.2015 09:13, David Holmes wrote: On 4/08/2015 5:10 PM, Jaroslav Bachorik wrote: Hi David, On 4.8.2015 02:25, David Holmes wrote: On 4/08/2015 1:31 AM, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.ope

Re: RFR 8041565: JMX ObjectName could be refactored to save memory

2015-08-05 Thread Jaroslav Bachorik
Eamonn, Daniel, thanks for the comments. I've updated the webrev to address them. Also, I've added a test to exercise the boolean flag en-/decoding in ObjectName. http://cr.openjdk.java.net/~jbachorik/8041565/webrev.03 Cheers, -JB- On 4.8.2015 23:02, Daniel Fuchs wrote: Hi Jaroslav, 3