Re: RFR: 8130115: REDO - Reduce Symbol::_identity_hash to 2 bytes

Ioi, I am trying to add a test case in SA for the testing as you mentioned. The easy part is adding a simple SA Tool (SymbolsInfo.java) to get the Symbol information but encountered a problem as: In the testing java process (1), create (spawn) another java process(2), which will run SA

Re: RFR(S) 8080401: Uninitialised variable in hotspot/src/os/solaris/dtrace/

On 8/7/15 06:45, Dmitry Samersoff wrote: Serguei, Looks good for me. Thanks a lot! It might be better to use (uint64_t) -1 for initialization of pc_diff in libjvm_db.c Thank you for the suggestion. It'd work but not that important. :) Thanks, Serguei -Dmitry On 2015-08-07 13:25

Re: RFR(S) 8080401: Uninitialised variable in hotspot/src/os/solaris/dtrace/

Serguei, Looks good for me. It might be better to use (uint64_t) -1 for initialization of pc_diff in libjvm_db.c -Dmitry On 2015-08-07 13:25, serguei.spit...@oracle.com wrote: > > Please, review the jdk 9 fix for: > https://bugs.openjdk.java.net/browse/JDK-8080401 > > > Open webrev: > htt

Re: RFR(S) 8033577: [parfait] warnings from b128 for hotspot/src/os/solaris/dtrace: Unportable format string argument mismatch

Thanks, Dmitry! May I ask you to look at another parfait fix (8080401)? I hope, it is simple enough. Thanks, Serguei On 8/7/15 05:11, Dmitry Samersoff wrote: Looks good for me. On 2015-08-07 13:21, serguei.spit...@oracle.com wrote: Re-posting this with the updated subject line. Please, revie

Re: RFR(S) 8033577: [parfait] warnings from b128 for hotspot/src/os/solaris/dtrace: Unportable format string argument mismatch

Looks good for me. On 2015-08-07 13:21, serguei.spit...@oracle.com wrote: > Re-posting this with the updated subject line. > > Please, review the jdk 9 fix for: > https://bugs.openjdk.java.net/browse/JDK-8033577 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8033577

Re: RFR(S) 8033577: [parfait] warnings from b128 for hotspot/src/os/solaris/dtrace: Unportable format string argument mismatch

Thanks, Staffan! Serguei On 8/7/15 04:23, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 7 aug 2015, at 12:21, serguei.spit...@oracle.com wrote: Re-posting this with the updated subject line. Please, review the jdk 9 fix for: https://bugs.openjdk.java.net/browse/JDK-8033577 Open w

Re: RFR(S) 8080401: Uninitialised variable in hotspot/src/os/solaris/dtrace/

Thanks, Staffan! Serguei On 8/7/15 04:22, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 7 aug 2015, at 12:25, serguei.spit...@oracle.com wrote: Please, review the jdk 9 fix for: https://bugs.openjdk.java.net/browse/JDK-8080401 Open webrev: http://cr.openjdk.java.net/~sspitsyn/we

Re: RFR(S) 8033577: [parfait] warnings from b128 for hotspot/src/os/solaris/dtrace: Unportable format string argument mismatch

Looks good! Thanks, /Staffan > On 7 aug 2015, at 12:21, serguei.spit...@oracle.com wrote: > > Re-posting this with the updated subject line. > > Please, review the jdk 9 fix for: > https://bugs.openjdk.java.net/browse/JDK-8033577 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs

Re: RFR(S) 8080401: Uninitialised variable in hotspot/src/os/solaris/dtrace/

Looks good! Thanks, /Staffan > On 7 aug 2015, at 12:25, serguei.spit...@oracle.com wrote: > > > Please, review the jdk 9 fix for: > https://bugs.openjdk.java.net/browse/JDK-8080401 > > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8080401-dtrace-parfait2.1/ > >

RFR(S) 8080401: Uninitialised variable in hotspot/src/os/solaris/dtrace/

Please, review the jdk 9 fix for: https://bugs.openjdk.java.net/browse/JDK-8080401 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8080401-dtrace-parfait2.1/ Summary: The fix includes the parfait issues listed in the bug report. Testing: The JPRT build Thanks

RFR(S) 8033577: [parfait] warnings from b128 for hotspot/src/os/solaris/dtrace: Unportable format string argument mismatch

Re-posting this with the updated subject line. Please, review the jdk 9 fix for: https://bugs.openjdk.java.net/browse/JDK-8033577 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8033577-dtrace-parfait1.1/ Summary: The fix includes: - the parfait fixes listed in th

RFR(S) 8033577:

Please, review the jdk 9 fix for: https://bugs.openjdk.java.net/browse/JDK-8033577 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8033577-dtrace-parfait1.1/ Summary: The fix includes: - the parfait fixes listed in the bug report and - a couple of adjustments fo

Re: RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

Ok. Thanks, Staffan! Serguei On 8/7/15 2:27 AM, Staffan Larsen wrote: On 7 aug 2015, at 11:24, serguei.spit...@oracle.com wrote: Hi Staffan, Looks good. Thanks! I'm re-posting the same question in this review: Q1: Should the folder jdk/src/demo/s

Re: RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

Dmitry, On 8/7/15 2:31 AM, Dmitry Samersoff wrote: Serguei, Q1: Should the folder jdk/src/demo/share/jvmti/java_crw_demo also be removed? Yes. See https://bugs.openjdk.java.net/browse/JDK-8041639 Thank you for the comment. But, please, see also the related comment from Staffan. Thanks,

Re: RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

Serguei, > Q1: Should the folder jdk/src/demo/share/jvmti/java_crw_demo also be > removed? Yes. See https://bugs.openjdk.java.net/browse/JDK-8041639 -Dmitry On 2015-08-07 12:24, serguei.spit...@oracle.com wrote: > Hi Staffan, > > Looks good. > > I'm re-posting the same question in this review

Re: RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

> On 7 aug 2015, at 11:24, serguei.spit...@oracle.com wrote: > > Hi Staffan, > > Looks good. Thanks! > > I'm re-posting the same question in this review: > Q1: Should the folder jdk/src/demo/share/jvmti/java_crw_demo also be > removed? No, it is used by some of the demos (mtrace, minst, e

Re: RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

Hi Staffan, Looks good. I'm re-posting the same question in this review: Q1: Should the folder jdk/src/demo/share/jvmti/java_crw_demo also be removed? Thanks, Serguei On 8/6/15 11:57 PM, Staffan Larsen wrote: Please review the following changes to remove the hprof JVMTI agent. There are