RFR(S): 8086134 Deadlock detection fails to attach to core file

2015-08-19 Thread Dmitry Samersoff
Everybody, Please, review test-only fix. http://cr.openjdk.java.net/~dsamersoff/JDK-8086134/webrev.01/ The test is rewritten to use testlibrary and to detect common bad environment conditions. Tests in Hotspot and JDK workspaces are identical, except imports and the fact that JDK version runs

Re: RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector

2015-08-19 Thread Jaroslav Bachorik
On 19.8.2015 16:32, Alan Bateman wrote: On 19/08/2015 15:01, Jaroslav Bachorik wrote: : There are several tests in jdk/test/javax/management that exercise IIOP if available, shouldn't they be updated too? Not sure about this. These tests are also exercising JMXMP if available - but that h

Re: RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector

2015-08-19 Thread Alan Bateman
On 19/08/2015 15:01, Jaroslav Bachorik wrote: : There are several tests in jdk/test/javax/management that exercise IIOP if available, shouldn't they be updated too? Not sure about this. These tests are also exercising JMXMP if available - but that has never been a part of JDK. I think the

Re: RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector

2015-08-19 Thread Jaroslav Bachorik
On 19.8.2015 15:05, Alan Bateman wrote: On 19/08/2015 13:51, Jaroslav Bachorik wrote: I hope I got it all this time. Used brute force search for any mention of 'iiop' and removed anything that had anything to do with JMX. Top level: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.02 JDK:

Re: RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector

2015-08-19 Thread Alan Bateman
On 19/08/2015 13:51, Jaroslav Bachorik wrote: I hope I got it all this time. Used brute force search for any mention of 'iiop' and removed anything that had anything to do with JMX. Top level: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.02 JDK: http://cr.openjdk.java.net/~jbachorik/8

Re: RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector

2015-08-19 Thread Jaroslav Bachorik
On 19.8.2015 13:20, Alan Bateman wrote: On 19/08/2015 11:47, Jaroslav Bachorik wrote: Top level changes: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.01/ JDK changes: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.01/jdk I think you also need to look at jake/make/rmic/Rmic-java.ma

Re: RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector

2015-08-19 Thread Alan Bateman
On 19/08/2015 11:47, Jaroslav Bachorik wrote: Top level changes: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.01/ JDK changes: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.01/jdk I think you also need to look at jake/make/rmic/Rmic-java.management.gmk which is where RMICONNECTOR

Re: RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector

2015-08-19 Thread Jaroslav Bachorik
On 19.8.2015 11:02, Alan Bateman wrote: On 19/08/2015 09:59, Jaroslav Bachorik wrote: I missed this. However, I have my doubts about 'common/autoconf/generated-configure.sh' - the comment says this file should not be edited but it was changed in the aforementioned commit. Should I change it b

Re: RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector

2015-08-19 Thread Alan Bateman
On 19/08/2015 09:59, Jaroslav Bachorik wrote: I missed this. However, I have my doubts about 'common/autoconf/generated-configure.sh' - the comment says this file should not be edited but it was changed in the aforementioned commit. Should I change it back? You will need to edit spec.gmk.in

Re: RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector

2015-08-19 Thread Jaroslav Bachorik
On 19.8.2015 08:19, Alan Bateman wrote: On 18/08/2015 15:35, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043937 Webrev: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.00 For Java SE 8, JSR 160 was updated to downgrade the

Re: RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector

2015-08-19 Thread Jaroslav Bachorik
On 19.8.2015 08:19, Alan Bateman wrote: On 18/08/2015 15:35, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043937 Webrev: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.00 For Java SE 8, JSR 160 was updated to downgrade the