Re: RFR: JDK-8134030: test/serviceability/dcmd/gc/HeapDumpTest fails to verify the dump

On 3/11/2015 9:10 PM, Andreas Eriksson wrote: On 2015-11-03 07:27, David Holmes wrote: Hi Andreas, On 31/10/2015 12:03 AM, Andreas Eriksson wrote: Hi, Please review this change to heap dump logic. Including runtime list, since this is related to class loading. Bug: JDK-8134030: test/servic

Re: RFR: JDK-8140556: Add force rotation option to VM.log jcmd

On 4/11/2015 12:45 AM, Yasumasa Suenaga wrote: David, Marcus, I'm unclear of the context in which this could be called by an unattached thread (ie during early VM initialization). Could you clarify the code-path for me please? It seems an odd check to make on all rotate() requests rather then d

Re: RFR(M): 8140482: Various minor code improvements (runtime)

Hi Goetz, On 4/11/2015 12:10 AM, Lindenmaier, Goetz wrote: Hi David, the new scan is already through. I made a new webrev: http://cr.openjdk.java.net/~goetz/webrevs/8140482-covRt/webrev.01/ attachListener_linux.cpp: I had moved the string termination out of the loop, and read one less char fro

Re: RFR: JDK-8140556: Add force rotation option to VM.log jcmd

David, Marcus, I'm unclear of the context in which this could be called by an unattached thread (ie during early VM initialization). Could you clarify the code-path for me please? It seems an odd check to make on all rotate() requests rather then doing something only in the problematic case.

Re: jmx-dev RFR 6425769: jmx remote bind address

On 2.11.2015 19:06, Severin Gehwolf wrote: Hi, Thanks Jaroslav and Daniel for the reviews! Comments inline. On Mon, 2015-11-02 at 16:54 +0100, Jaroslav Bachorik wrote: > Hi, > > On 2.11.2015 16:19, Daniel Fuchs wrote: >> Hi Severin, >> >> Adding serviceability-dev@openjdk.java.net into the loop

RE: RFR(M): 8140482: Various minor code improvements (runtime)

Hi David, the new scan is already through. I made a new webrev: http://cr.openjdk.java.net/~goetz/webrevs/8140482-covRt/webrev.01/ attachListener_linux.cpp: I had moved the string termination out of the loop, and read one less char from the file. The scan still claims "Passing unterminated strin

Re: RFR: JDK-8134030: test/serviceability/dcmd/gc/HeapDumpTest fails to verify the dump

On 2015-11-03 07:27, David Holmes wrote: Hi Andreas, On 31/10/2015 12:03 AM, Andreas Eriksson wrote: Hi, Please review this change to heap dump logic. Including runtime list, since this is related to class loading. Bug: JDK-8134030: test/serviceability/dcmd/gc/HeapDumpTest fails to verify t

Re: RFR(M): 8140482: Various minor code improvements (runtime)

Hi Goetz, Quick follow up on a couple of things ... On 3/11/2015 7:33 PM, Lindenmaier, Goetz wrote: Hi David, Sorry, lots of folks very busy at the moment as we try to get features finalized before the deadline. thanks for looking at this! I know the Dec. 10 deadline, but I guess that also

Re: RFR(M): 8140482: Various minor code improvements (runtime)

Oops see what you mean about attachListener_windows.cpp now: if (strlen(arg0) > AttachOperation::arg_length_max) return ATTACH_ERROR_ILLEGALARG; if (strlen(arg0) > AttachOperation::arg_length_max) return ATTACH_ERROR_ILLEGALARG; Should be arg0, arg1 and arg2. David On 3/11/2015 8:07 PM,

Re: Let jvmtiGen exit with a non-zero exit code upon failure

Looks good! Thanks, /Staffan > On 2 nov. 2015, at 19:54, Carsten Varming wrote: > > Dear Staffan, > > I updated the webrev at http://cr.openjdk.java.net/~cvarming/jvmtiGen.02/ > > > I kept the verbose flag to avoid printing the fallback war

RE: RFR(M): 8140482: Various minor code improvements (runtime)

Hi David, > Sorry, lots of folks very busy at the moment as we try to get features > finalized before the deadline. thanks for looking at this! I know the Dec. 10 deadline, but I guess that also holds for us ... at least J1 is over now. (Unfortunately we could not attend this year.) > > ps_cor