Re: RFR: JDK-8140556: Add force rotation option to VM.log jcmd

On 5/11/2015 1:30 PM, Yasumasa Suenaga wrote: I've uploaded new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8140556/webrev.03/ I added _initialized to LogConfiguration. LogConfiguration::post_initialize() will be called after main thread initialization. So _initialized set to true in thi

Re: RFR(M): 8140482: Various minor code improvements (runtime)

Hi Goetz, The fix looks good. Thanks for the improvements! The _NSIG related fix looks Ok to me but I do not feel myself qualified to make a final decision. A couple of minor comments: *src/share/vm/libadt/dict.cpp* 149 nb->_keyvals[nbcnt + nbcnt + 1] = b->_keyvals[j+j+1]; 152 b->_keyvals[j+

Re: RFR: JDK-8140556: Add force rotation option to VM.log jcmd

I've uploaded new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8140556/webrev.03/ I added _initialized to LogConfiguration. LogConfiguration::post_initialize() will be called after main thread initialization. So _initialized set to true in this function, and we can check this flag at rotat

Re: Collect thread dumps of all Java process on localhost

Mandy, Thanks, I got it to work using your suggestions. Keimpe Bronkhorst Oracle JDeveloper On 11/4/2015 5:02 PM, Mandy Chung wrote: On Nov 4, 2015, at 2:32 PM, Keimpe Bronkhorst wrote: This concerns code we have in Oracle JDeveloper which collect thread dumps of all Java Processes on loc

Re: Collect thread dumps of all Java process on localhost

> On Nov 4, 2015, at 2:32 PM, Keimpe Bronkhorst > wrote: > > This concerns code we have in Oracle JDeveloper which collect thread dumps of > all Java Processes on local host. This code uses the non-public JDK classes: > import sun.jvmstat.monitor.MonitorException; > import sun.jvmstat.

Re: RFR: 8138916: Logging write function does not allow for long enough messages

Great, thank you, Marcus! Rachel On 11/4/2015 2:59 PM, Marcus Larsson wrote: Looks good! Regards, Marcus On 2015-11-04 20:49, Rachel Protacio wrote: Updated webrev with this fgets change: http://cr.openjdk.java.net/~rprotacio/8139564.04/ Passes JPRT tests. Thank you, Rachel On 11/4/2015 4

Collect thread dumps of all Java process on localhost

This concerns code we have in Oracle JDeveloper which collect thread dumps of all Java Processes on local host. This code uses the non-public JDK classes: import sun.jvmstat.monitor.MonitorException; import sun.jvmstat.monitor.MonitoredHost; import sun.jvmstat.monitor.MonitoredVm;

Re: RFR: 8138916: Logging write function does not allow for long enough messages

Looks good! Regards, Marcus On 2015-11-04 20:49, Rachel Protacio wrote: Updated webrev with this fgets change: http://cr.openjdk.java.net/~rprotacio/8139564.04/ Passes JPRT tests. Thank you, Rachel On 11/4/2015 4:59 AM, Marcus Larsson wrote: Hmm, I just noticed that the test doesn't null te

Re: RFR: 8138916: Logging write function does not allow for long enough messages

Updated webrev with this fgets change: http://cr.openjdk.java.net/~rprotacio/8139564.04/ Passes JPRT tests. Thank you, Rachel On 11/4/2015 4:59 AM, Marcus Larsson wrote: Hmm, I just noticed that the test doesn't null terminate the string it reads from file. Replacing the fgetc loop with a cal

Re: RFR: 8138916: Logging write function does not allow for long enough messages

Thanks for the review, Marcus. I'll make that change. Rachel On 11/4/2015 4:59 AM, Marcus Larsson wrote: Hmm, I just noticed that the test doesn't null terminate the string it reads from file. Replacing the fgetc loop with a call to fgets should fix this. Regards, Marcus On 2015-11-04 10:49

Re: RFR: JDK-8134030: test/serviceability/dcmd/gc/HeapDumpTest fails to verify the dump

On 2015-11-04 08:31, David Holmes wrote: On 3/11/2015 9:10 PM, Andreas Eriksson wrote: On 2015-11-03 07:27, David Holmes wrote: Hi Andreas, On 31/10/2015 12:03 AM, Andreas Eriksson wrote: Hi, Please review this change to heap dump logic. Including runtime list, since this is related to c

Re: jmx-dev RFR 6425769: jmx remote bind address

Hi, Updated webrev with jtreg test in Java: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-6425769/02/ bug: https://bugs.openjdk.java.net/browse/JDK-6425769 I believe this updated webrev addresses all concerns and incorporates suggestions brought up by Jaroslav and Daniel. I'm still looking fo

Re: RFR: 8138916: Logging write function does not allow for long enough messages

Hmm, I just noticed that the test doesn't null terminate the string it reads from file. Replacing the fgetc loop with a call to fgets should fix this. Regards, Marcus On 2015-11-04 10:49, Marcus Larsson wrote: Looks good, thank you for fixing this! Regards, Marcus On 2015-11-02 19:03, Rac

Re: RFR: 8138916: Logging write function does not allow for long enough messages

Looks good, thank you for fixing this! Regards, Marcus On 2015-11-02 19:03, Rachel Protacio wrote: Thanks for the comments, Marcus. I've undone the "logtest" tag and instead created an InternalVMTest in log.cpp that writes the 518-character string to a temporary file and looks for it there. U

Re: RFR(M): 8140482: Various minor code improvements (runtime)

On 4/11/2015 6:01 PM, Lindenmaier, Goetz wrote: Hi David, attachListener.hpp: I agree that I can not find another possible issue with the strcpy. Still I think it's better to have the strncpy, as it would have protected against the bug in attachListener_windows.cpp. But if you insist I'll just r

RE: RFR(M): 8140482: Various minor code improvements (runtime)

Hi David, attachListener.hpp: I agree that I can not find another possible issue with the strcpy. Still I think it's better to have the strncpy, as it would have protected against the bug in attachListener_windows.cpp. But if you insist I'll just remove it. Should I remove the _NSIG issue from