Re: jmx-dev RFR 6425769: jmx remote bind address

2015-11-09 Thread Severin Gehwolf
On Wed, 2015-11-04 at 11:54 +0100, Severin Gehwolf wrote: > Hi, > > Updated webrev with jtreg test in Java: > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-6425769/02/ > bug: https://bugs.openjdk.java.net/browse/JDK-6425769 > > I believe this updated webrev addresses all concerns and incorpora

RFR: 8141591 : javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2015-11-09 Thread Alexander Kulyakhtin
Hi, Could you, please, review this test-only fix: CR: https://bugs.openjdk.java.net/browse/JDK-8141591 Webrev: http://cr.openjdk.java.net/~akulyakh/8141591_01/test/javax/management/remote/mandatory/threads/ExecutorTest.java.udiff.html Before the fix, it was possible that we shut down the execut

Re: RFR: 8141591 : javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2015-11-09 Thread Jaroslav Bachorik
Hi Alexander, On 9.11.2015 16:40, Alexander Kulyakhtin wrote: Hi, Could you, please, review this test-only fix: CR: https://bugs.openjdk.java.net/browse/JDK-8141591 Webrev: http://cr.openjdk.java.net/~akulyakh/8141591_01/test/javax/management/remote/mandatory/threads/ExecutorTest.java.udiff.h

Re: RFR: 8141591 : javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2015-11-09 Thread Alexander Kulyakhtin
Hi Jaroslav, Thank you very much for the review. I wanted to use the bound version of the await(timeout) to provide for a better output in case the test fails. Would you advise just to replace with no-args await() or is it possible to somehow distinguish for L175 and other platforms where possi

Re: RFR: 8141591 : javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2015-11-09 Thread Alexander Kulyakhtin
Hi, Following the comments from Jaroslav and Martin I've changed the test to use the unbound CountDownLatch.await() Since await() will wait undefinitely and thus the test, if fails, will now fail by timeout only the code has been additionally simplified to reflect that. Please, find the upd

Re: RFR: 8141591 : javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2015-11-09 Thread Martin Buchholz
The traditional way is to have all the worker tasks count down a latch when they're started and have the master thread wait on that before proceeding. You can use test.timeout.factor to do a scaled timed wait. On Mon, Nov 9, 2015 at 8:03 AM, Jaroslav Bachorik < jaroslav.bacho...@oracle.com> wrote

RFR: JDK-8142336: Convert the SA agent build to modular build-infra makefiles

2015-11-09 Thread Erik Joelsson
Hello, As a stepping stone in the hotspot makefile conversion, I have broken out the serviceability agent separately and converted it into proper modular build-infra makefiles. Doing this conversion separately has some value on its own by reducing the special cases currently needed for buildi

RFR (S) 8079408 - Improve class loading log (with unified logging)

2015-11-09 Thread Ioi Lam
Please review a small fix, related to unified logging: http://cr.openjdk.java.net/~iklam/8079408-improve-class-load-log/ Bug: 8079408 Improve class loading log (with unified logging) https://bugs.openjdk.java.net/browse/JDK-8079408 Summary of fix: This fix has 2 parts: [a] Reimpl

RFR: 8142366: Add develop_debug and develop_trace levels to Unified Logging

2015-11-09 Thread Rachel Protacio
Hello, Please see my small changeset to add two develop levels to UL. Summary: This adds develop (that is, non-product) logging levels to the Unified Logging framework in order to support performance, footprint, and usefulness-of-output considerations while maintaining the ability for the use