Re: RFR(M): 8141529: Fix handling of _JAVA_SR_SIGNUM

2015-11-16 Thread Thomas Stüfe
Hi Götz, looks good! ..Thomas On Mon, Nov 16, 2015 at 11:25 AM, Lindenmaier, Goetz < goetz.lindenma...@sap.com> wrote: > Hi Thomas, > > > > thanks for looking at this. > > > > > MAX2(SIGSEGV, SIGBUS) > > I really would like to leave the code as-is. This would be a functional > > change, while

RE: RFR(M): 8141529: Fix handling of _JAVA_SR_SIGNUM

2015-11-16 Thread Lindenmaier, Goetz
Hi Dmitry, I think this is a rather complex issue which is better documented in the bug than in the code. The code already references the bugID. Also, I would have to copy the explanation into three files ... I you don't object I'll leave the comment as is. Best regards, Goetz. -Origina

RE: RFR(M): 8141529: Fix handling of _JAVA_SR_SIGNUM

2015-11-16 Thread Lindenmaier, Goetz
Hi Thomas, thanks for looking at this. > MAX2(SIGSEGV, SIGBUS) I really would like to leave the code as-is. This would be a functional change, while I only intend to fix issues in this change. Also, as David explained, it might break for some os implementations. > the only way to initialize it

Re: RFR(M): 8141529: Fix handling of _JAVA_SR_SIGNUM

2015-11-16 Thread David Holmes
On 16/11/2015 7:45 PM, Thomas Stüfe wrote: Hi David, On Mon, Nov 16, 2015 at 5:03 AM, David Holmes mailto:david.hol...@oracle.com>> wrote: On 13/11/2015 11:38 PM, David Holmes wrote: On 13/11/2015 7:53 PM, Thomas Stüfe wrote: Hi Goetz, sorry for not lookin

Re: RFR(M): 8141529: Fix handling of _JAVA_SR_SIGNUM

2015-11-16 Thread Dmitry Samersoff
Goetz, On 2015-11-16 13:32, Lindenmaier, Goetz wrote: > Hi Dmitry, > > I think this is a rather complex issue which is better documented in the > bug than in the code. The code already references the bugID. > Also, I would have to copy the explanation into three files ... > I you don't object

Re: RFR(M): 8141529: Fix handling of _JAVA_SR_SIGNUM

2015-11-16 Thread Dmitry Samersoff
Goetz, Looks good for me. Thank you for a nice cleanup. -Dmitry On 2015-11-16 13:25, Lindenmaier, Goetz wrote: > Hi Thomas, > > > > thanks for looking at this. > > > >> MAX2(SIGSEGV, SIGBUS) > > I really would like to leave the code as-is. This would be a functional > > change, whil

RE: RFR(M): 8141529: Fix handling of _JAVA_SR_SIGNUM

2015-11-16 Thread Lindenmaier, Goetz
Hi David, thanks for looking into this issue. I'll leave the coding as is. Best regards, Goetz. -Original Message- From: David Holmes [mailto:david.hol...@oracle.com] Sent: Montag, 16. November 2015 05:04 To: Thomas Stüfe; Lindenmaier, Goetz Cc: serviceability-dev; hotspot-runtime-..

Re: RFR(M): 8141529: Fix handling of _JAVA_SR_SIGNUM

2015-11-16 Thread Thomas Stüfe
Hi David, On Mon, Nov 16, 2015 at 5:03 AM, David Holmes wrote: > On 13/11/2015 11:38 PM, David Holmes wrote: > >> On 13/11/2015 7:53 PM, Thomas Stüfe wrote: >> >>> Hi Goetz, >>> >>> sorry for not looking at this earlier. This is a nice cleanup. Some >>> remarks: >>> >>> >>> http://cr.openjdk.jav

Re: RFR(M): 8141529: Fix handling of _JAVA_SR_SIGNUM

2015-11-16 Thread Dmitry Samersoff
David, Thank you for detailed explanation. Could we put it as a comment right into the code? -Dmitry On 2015-11-16 07:03, David Holmes wrote: > On 13/11/2015 11:38 PM, David Holmes wrote: >> On 13/11/2015 7:53 PM, Thomas Stüfe wrote: >>> Hi Goetz, >>> >>> sorry for not looking at this earlier. T