Re: RFR[ 9u-dev] JDK-8138745: Implement ExitOnOutOfMemory and CrashOnOutOfMemory in HotSpot

2015-12-02 Thread cheleswer sahu
Hi, Thanks David and Staffan for your comments. Please review the code changes in the updated webrev below http://cr.openjdk.java.net/~kevinw/8138745/webrev.01/ Regards, Cheleswer On 11/26/2015 11:58 AM, David Holmes wrote: Sorry forgot the tests test/runtime/ErrorHandling/TestExitOnOut

PING: RFR: JDK-8140556: Add force rotation option to VM.log jcmd

2015-12-02 Thread Yasumasa Suenaga
PING: Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8140556/webrev.04/ I need reviewer and sponsor. Thanks, Yasumasa 2015/11/15 21:50 "Yasumasa Suenaga" : > > PING: Could you review it? > http://cr.openjdk.java.net/~ysuenaga/JDK-8140556/webrev.04/ > > Yasumasa > > > On 2015/

Re: RFR: 8144220: UL does not support full path names for log files on windows

2015-12-02 Thread Bengt Rutisson
Hi Marcus, On 2015-12-02 15:28, Marcus Larsson wrote: Hi Bengt, Thanks for looking at this. On 2015-12-02 14:59, Bengt Rutisson wrote: Hi Marcus, On 2015-12-02 14:41, Marcus Larsson wrote: Hi, Please review the following patch to allow full path names for log files on windows. The fu

Re: RFR: 8144220: UL does not support full path names for log files on windows

2015-12-02 Thread Marcus Larsson
Hi Bengt, Thanks for looking at this. On 2015-12-02 14:59, Bengt Rutisson wrote: Hi Marcus, On 2015-12-02 14:41, Marcus Larsson wrote: Hi, Please review the following patch to allow full path names for log files on windows. The full path to files will on windows contain a colon (from th

Re: RFR: 8144220: UL does not support full path names for log files on windows

2015-12-02 Thread Bengt Rutisson
Hi Marcus, On 2015-12-02 14:41, Marcus Larsson wrote: Hi, Please review the following patch to allow full path names for log files on windows. The full path to files will on windows contain a colon (from the C:\ part), and there used to be no way to avoid that colon from being parsed as

RFR: 8144220: UL does not support full path names for log files on windows

2015-12-02 Thread Marcus Larsson
Hi, Please review the following patch to allow full path names for log files on windows. The full path to files will on windows contain a colon (from the C:\ part), and there used to be no way to avoid that colon from being parsed as the delimiter for the next -Xlog: option. With this patch

Re: RFR : JDK-8139985: JNI exception pending in jdk/src/jdk/hprof/agent/share/native/libhprof/

2015-12-02 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 2 dec. 2015, at 04:33, Jini George wrote: > > Hi all, > > This is a review request for the following defect related to Parfait cleanup: > > https://bugs.openjdk.java.net/browse/JDK-8139985 > (JNI exception

RE: RFR : JDK-8139985: JNI exception pending in jdk/src/jdk/hprof/agent/share/native/libhprof/

2015-12-02 Thread Jini George
Thank you Dmitry. -jini > -Original Message- > From: Dmitry Samersoff > Sent: Wednesday, December 02, 2015 2:43 PM > To: Jini George; serviceability-dev@openjdk.java.net > Subject: Re: RFR : JDK-8139985: JNI exception pending in > jdk/src/jdk/hprof/agent/share/native/libhprof/ > > Jini,

Re: RFR : JDK-8139985: JNI exception pending in jdk/src/jdk/hprof/agent/share/native/libhprof/

2015-12-02 Thread Dmitry Samersoff
Jini, Looks good for me. (Reviewed) -Dmitry On 2015-12-02 06:33, Jini George wrote: > Hi all, > > This is a review request for the followingdefectrelated to Parfait cleanup: > > _https://bugs.openjdk.java.net/browse/JDK-8139985_ (JNI exception > pending in jdk/src/jdk/hprof/agent/share/nativ