Re: RFR: 8144220: UL does not support full path names for log files on windows

Hi, New webrev: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.00-01/ Added more test cases to the test, and renamed it to TestQuotedLogOutputs. The updated test found that partially quoted output names that didn't start

Re: PING: RFR: JDK-8140556: Add force rotation option to VM.log jcmd

Hi, On 2015-12-03 04:33, Yasumasa Suenaga wrote: PING: Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8140556/webrev.04/ I need reviewer and sponsor. Looks good. I'll sponsor. Regards, Marcus Thanks, Yasuma

Re: RFR 8141526: Allow to collect stdout/stderr from the FinalizationRunner even before the process returns

On 25.11.2015 22:51, Dmitry Samersoff wrote: Jaroslav, Looks good for me. PS: I found a bug in canPtraceAttachLinux not related to your changes - it's probably my mistake: 181 if (userName.equals("root")) { 182 return true; 183 } shouldn't be there. Could yo

Re: RFR[ 9u-dev] JDK-8138745: Implement ExitOnOutOfMemory and CrashOnOutOfMemory in HotSpot

Hello, I think "binary crash file" is not a clear wording, it made me wonder if this is a hprof heap dump. It should explicitely say "sytem core dump, when enabled". (The webrev below did not contain actual crash-code, is it already commited?). BTW, rejecting large array allocations could be a

Re: PING: RFR: JDK-8140556: Add force rotation option to VM.log jcmd

Looks good! Thanks, /Staffan > On 3 dec. 2015, at 04:33, Yasumasa Suenaga wrote: > > PING: Could you review it? > http://cr.openjdk.java.net/~ysuenaga/JDK-8140556/webrev.04/ > > I need reviewer and sponsor. > > Thanks, > > Yasumasa > > 2015/11/15 21:50 "Yasumasa Suenaga" : >> >> PING: Cou

Re: RFR 8141526: Allow to collect stdout/stderr from the FinalizationRunner even before the process returns

Jaroslav, Looks good for me! -Dmitry On 2015-12-03 14:09, Jaroslav Bachorik wrote: > On 25.11.2015 22:51, Dmitry Samersoff wrote: >> Jaroslav, >> >> Looks good for me. >> >> PS: I found a bug in canPtraceAttachLinux not related to your changes - >> it's probably my mistake: >> >> 181

Re: RFR: 8144220: UL does not support full path names for log files on windows

Hi Marcus, On 2015-12-03 11:11, Marcus Larsson wrote: Hi, New webrev: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.00-01/ Looks good. One small detail: I think the test should have the annotation "@bug 8144220". No

Re: RFR: 8144220: UL does not support full path names for log files on windows

Hi, On 2015-12-03 13:32, Bengt Rutisson wrote: Hi Marcus, On 2015-12-03 11:11, Marcus Larsson wrote: Hi, New webrev: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.00-01/ Looks good. One small detail: I think the te

RFR(S): JDK-8131694 backout the fix for JDK-8131331 when JDK-8131693 is fixed

Everybody, Please review: http://cr.openjdk.java.net/~dsamersoff/JDK-8131694/webrev.01/ -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.

Re: RFR(S): JDK-8131694 backout the fix for JDK-8131331 when JDK-8131693 is fixed

On 12/3/15 1:01 PM, Dmitry Samersoff wrote: Everybody, Please review: http://cr.openjdk.java.net/~dsamersoff/JDK-8131694/webrev.01/ src/share/vm/runtime/vframe.cpp No comments. The backout of the fix for JDK-8131331 looks fine. Did you run the tmtools test suite to verify? Are there oth

RFR: JDK-8140031: SA: Searching for a value in Threads does not work

Hello, Please review the changes for the following fix: Bug: JDK-8140031: SA: Searching for a value in Threads does not work Fix: These changes improve the threads related commands in clhsdb 1. 'threads' command now prints the detailed information about threads. 2. 'thread' command now prints t

Re: RFR: JDK-8140031: SA: Searching for a value in Threads does not work

Poonam, Thank you for fixing it. Looks good for me! -Dmitry On 2015-12-04 01:31, Poonam Bajaj Parhar wrote: > Hello, > > Please review the changes for the following fix: > > Bug: JDK-8140031: SA: Searching for a value in Threads does not work > > Fix: These changes improve the threads relat