Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

2015-12-09 Thread Rachel Protacio
Hi, (Sorry if this sent twice. Thunderbird is acting up.) Thanks for the review. Replies inline. Updated webrev: http://cr.openjdk.java.net/~rprotacio/8141211.01/ On 12/8/2015 10:53 PM, David Holmes wrote: Hi Rachel, On 9/12/2015 1:42 AM, Rachel Protacio wrote: Hello, Please review my conve

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

2015-12-09 Thread Rachel Protacio
Hi, Thanks for the review. Replies inline. Updated webrev: http://cr.openjdk.java.net/~rprotacio/8141211.01/ On 12/8/2015 10:53 PM, David Holmes wrote: Hi Rachel, On 9/12/2015 1:42 AM, Rachel Protacio wrote: Hello, Please review my conversion of -XX:+TraceExceptions to -Xlog:exceptions=info.

Re: [RFR] (M) 8143608: Don't 64-bit align start of InstanceKlass vtable, itable, and nonstatic_oopmap on 32-bit systems

2015-12-09 Thread Mikael Gerdin
On 2015-12-08 20:14, Chris Plummer wrote: [Adding serviceability-dev@openjdk.java.net] Hi Mikael, Thanks for pointing this out. I'll look into it some more. Are there any tests that should be failing as a result of this? I get the feeling no, since I see other issues here that existed before my

Re: [PING-2] RFR 6425769: jmx remote bind address

2015-12-09 Thread Severin Gehwolf
On Wed, 2015-12-09 at 14:58 +0100, Jaroslav Bachorik wrote: > On 9.12.2015 14:55, Severin Gehwolf wrote: > > On Tue, 2015-12-01 at 14:19 +0100, Severin Gehwolf wrote: > > > Hi Jaroslav, > > > > > > On Tue, 2015-12-01 at 12:33 +0100, Jaroslav Bachorik wrote: > > > > On 1.12.2015 11:17, Severin Gehw

Re: RFR: JDK-8144965: Show oop pointer in call frame at HSDB.

2015-12-09 Thread Jaroslav Bachorik
On 9.12.2015 13:43, Yasumasa Suenaga wrote: > Hi Jaroslav, > > Thank you for your comment. > >> L1926 - vf.getLocals().oopHandleAt(0) may return null; the result should >> be checked before calling toString() on it > > I've fixed it in new webrev: >http://cr.openjdk.java.net/~ysuenaga/JDK-81

Re: [PING-2] RFR 6425769: jmx remote bind address

2015-12-09 Thread Jaroslav Bachorik
On 9.12.2015 14:55, Severin Gehwolf wrote: On Tue, 2015-12-01 at 14:19 +0100, Severin Gehwolf wrote: Hi Jaroslav, On Tue, 2015-12-01 at 12:33 +0100, Jaroslav Bachorik wrote: On 1.12.2015 11:17, Severin Gehwolf wrote: On Mon, 2015-11-09 at 10:32 +0100, Severin Gehwolf wrote: On Wed, 2015-11-0

Re: [PING-2] RFR 6425769: jmx remote bind address

2015-12-09 Thread Severin Gehwolf
On Tue, 2015-12-01 at 14:19 +0100, Severin Gehwolf wrote: > Hi Jaroslav, > > On Tue, 2015-12-01 at 12:33 +0100, Jaroslav Bachorik wrote: > > On 1.12.2015 11:17, Severin Gehwolf wrote: > > > On Mon, 2015-11-09 at 10:32 +0100, Severin Gehwolf wrote: > > > > On Wed, 2015-11-04 at 11:54 +0100, Severin

Re: RFR: JDK-8144965: Show oop pointer in call frame at HSDB.

2015-12-09 Thread Yasumasa Suenaga
Hi Jaroslav, Thank you for your comment. > L1926 - vf.getLocals().oopHandleAt(0) may return null; the result should > be checked before calling toString() on it I've fixed it in new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8144965/webrev.01/ Could you review again? Thanks, Yasumas

Re: RFR: JDK-8144965: Show oop pointer in call frame at HSDB.

2015-12-09 Thread Jaroslav Bachorik
On 9.12.2015 01:59, Yasumasa Suenaga wrote: > Hi all, > > I use HSDB / CLHSDB when I have to analyze coredump image. > For example, if JVM is crashed in static JNI method (e.g. ZIP archive > operation), > I want to find oop (like "this" pointer) address from upper call frame. > > We can find it

Re: [PING] RFR: JDK-8144332: HSDB could not terminate when close button is pushed.

2015-12-09 Thread Jaroslav Bachorik
On 9.12.2015 02:01, Yasumasa Suenaga wrote: > Ping: > > Please review it. >http://cr.openjdk.java.net/~ysuenaga/JDK-8144332/webrev.00/ Looks good! -JB- > > > Thanks, > > Yasumasa > > > On 2015/12/01 23:35, Yasumasa Suenaga wrote: >> Hi all, >> >> When I ran HSDB through jhsdb, I could