Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

2015-12-23 Thread Rachel Protacio
Thank you, David! Rachel On 12/22/2015 11:26 PM, David Holmes wrote: Thanks Rachel - looks good. David On 22/12/2015 7:46 AM, Rachel Protacio wrote: Hi, Please take a look at my updated changeset! Webrev: http://cr.openjdk.java.net/~rprotacio/8141211.02/ I've fixed the multi-line statements

Re: RFR: JDK-8145788: JVM crashes with -XX:+EnableTracing

2015-12-23 Thread Yasumasa Suenaga
Hi David, >> 1. Initialize JavaThread before calling apply_ergo() in create_vm(). > > That is not likely to be an option - it would likely be far too > disruptive to the initialization sequence. Agree. Thus I choose 2. > We will have to wait for the tracing experts to have a good look at >

JDK-8067194: FYI, SA sources moved to jdk.hotspot.agent

2015-12-23 Thread Dmitry Samersoff
Everybody, FYI, I just pushed JDK-8067194 that move SA sources to modules-ready location: from hotspot/agent to hotspot/src/jdk.hotspot.agent Please, make sure you WS is updated correctly and if you have fixes that touch SA code in a queue, please re-merge it. -Dmitry -- Dmitry Samersoff Or

Re: RFR 8145127: VM warning: WaitForMultipleObjects timed out (0) ...

2015-12-23 Thread Ivan Gerasimov
Thank you David for review! Sincerely yours, Ivan On 23.12.2015 7:41, David Holmes wrote: Looks okay. Second review needed though. Thanks, David On 19/12/2015 10:28 PM, Ivan Gerasimov wrote: We will suspend the current thread if two conditions are satisfied: process_exiting != 0 and proc

RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2015-12-23 Thread Jaroslav Bachorik
Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8146015 Webrev: http://cr.openjdk.java.net/~jbachorik/8146015/webrev.00 The test fails for IPv6 addresses since the RMI expects an IPv6 address to be properly wrapped in '[]'. In addition to that the logic