Re: jmx-dev RFR 8143047: Re-examine javax/management/ImplementationVersion/ImplVersionTest.java

2016-01-06 Thread Eamonn McManus
Looks good to me (emcmanus) too. Éamonn 2016-01-06 7:04 GMT-08:00 Alan Bateman : > > > On 06/01/2016 11:00, Jaroslav Bachorik wrote: > >> On 5.1.2016 16:47, Eamonn McManus wrote: >> >>> OK. In that case I would suggest removing the checkVersion variable >>> since it is now always true, along wit

Re: jmx-dev RFR 8143047: Re-examine javax/management/ImplementationVersion/ImplVersionTest.java

2016-01-06 Thread Alan Bateman
On 06/01/2016 11:00, Jaroslav Bachorik wrote: On 5.1.2016 16:47, Eamonn McManus wrote: OK. In that case I would suggest removing the checkVersion variable since it is now always true, along with the logic from ImplVersionCommand for when it is false. Done. Also updated the test summary wordi

Re: RFR 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials

2016-01-06 Thread Jaroslav Bachorik
On 6.1.2016 12:19, David Holmes wrote: On 6/01/2016 8:21 PM, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8145919 Webrev: http://cr.openjdk.java.net/~jbachorik/8145919/webrev.00 On AArch64 machines running multiple test roun

Re: RFR 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials

2016-01-06 Thread David Holmes
On 6/01/2016 8:21 PM, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8145919 Webrev: http://cr.openjdk.java.net/~jbachorik/8145919/webrev.00 On AArch64 machines running multiple test rounds involving SSL connections in rapid su

Re: RFR 8143047: Re-examine javax/management/ImplementationVersion/ImplVersionTest.java

2016-01-06 Thread Jaroslav Bachorik
On 5.1.2016 16:47, Eamonn McManus wrote: OK. In that case I would suggest removing the checkVersion variable since it is now always true, along with the logic from ImplVersionCommand for when it is false. Done. Also updated the test summary wording as suggested by Alan: http://cr.openjdk.java.n

RFR 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials

2016-01-06 Thread Jaroslav Bachorik
Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8145919 Webrev: http://cr.openjdk.java.net/~jbachorik/8145919/webrev.00 On AArch64 machines running multiple test rounds involving SSL connections in rapid succession leads to error during SSL handshake.