RE: PING: RFR: JDK-8145788: JVM crashes with -XX:+EnableTracing

2016-01-12 Thread Markus Gronlund
Thanks David and Yasumasa, I will then proceed with checking in my suggestion. Thanks again Markus -Original Message- From: Yasumasa Suenaga [mailto:yasue...@gmail.com] Sent: den 11 januari 2016 11:09 To: Markus Gronlund; David Holmes Cc: serviceability-dev@openjdk.java.net Subject:

Re: [ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-12 Thread Jaroslav Bachorik
On 12.1.2016 11:47, serguei.spit...@oracle.com wrote: On 1/7/16 08:40, Daniel Fuchs wrote: Hi, This looks OK to me. I'm not sure I understand the full impact of the changes in getAddressesForLocalHost() though - so hopefully someone else will jump in to review that part... Hi Jaroslav, I do

RFR: JDK-8130063: Refactoring tmtools jstat and jstack tests to jtreg

2016-01-12 Thread Alexander Kulyakhtin
Hi, Could you, please, review the following test-only change CR: https://bugs.openjdk.java.net/browse/JDK-8130063 "Refactoring tmtools jstat and jstack tests to jtreg" WebRev: http://cr.openjdk.java.net/~akulyakh/8130063_01/ Before the change we had a set of tests verifying the correctness of

Re: PING: RFR: JDK-8145788: JVM crashes with -XX:+EnableTracing

2016-01-12 Thread Marcus Larsson
Hi Markus, Looks good! Thanks, Marcus On 01/12/2016 10:34 AM, Markus Gronlund wrote: Thanks David and Yasumasa, I will then proceed with checking in my suggestion. Thanks again Markus -Original Message- From: Yasumasa Suenaga [mailto:yasue...@gmail.com] Sent: den 11 januari 2016

RE: PING: RFR: JDK-8145788: JVM crashes with -XX:+EnableTracing

2016-01-12 Thread Markus Gronlund
Thanks Marcus for taking a look. /Markus -Original Message- From: Marcus Larsson Sent: den 12 januari 2016 15:29 To: Markus Gronlund; Yasumasa Suenaga; David Holmes Cc: serviceability-dev@openjdk.java.net Subject: Re: PING: RFR: JDK-8145788: JVM crashes with -XX:+EnableTracing Hi

Re: [ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-12 Thread serguei.spit...@oracle.com
On 1/7/16 08:40, Daniel Fuchs wrote: Hi, This looks OK to me. I'm not sure I understand the full impact of the changes in getAddressesForLocalHost() though - so hopefully someone else will jump in to review that part... Hi Jaroslav, I do not understand the full impact of the

Re: [ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-12 Thread serguei.spit...@oracle.com
On 1/12/16 03:49, Jaroslav Bachorik wrote: On 12.1.2016 11:47, serguei.spit...@oracle.com wrote: On 1/7/16 08:40, Daniel Fuchs wrote: Hi, This looks OK to me. I'm not sure I understand the full impact of the changes in getAddressesForLocalHost() though - so hopefully someone else will jump in