Re: RFR(S): JDK-8148104 HSDB could not terminate when launched on CLI.

2016-01-27 Thread KUBOTA Yuji
2016-01-26 19:56 GMT+09:00 Jaroslav Bachorik : > On 26.1.2016 11:54, Dmitry Samersoff wrote: >> >> Yuji, >> >> I think both changes are good so I add this patch to webrev. >> >> see: >> >> >> http://cr.openjdk.java.net/~dsamersoff/sponsorship/kubota.yuji/JDK-8148104/webrev.02/ > > > Thanks Yuji, Dm

Re: RFR(S, TESTONLY): JDK-8148315 Create a basic reproducer for JDI issues

2016-01-27 Thread Roger Riggs
Hi Dmitry, I have no particular problem with LingeredApp but it is one more special purpose test function. I had a similar problem with the process tests and created a JavaChild that accepts commands and produces useful stream output used to synchronize. It was just a thought that now with js

Re: RFR(S, TESTONLY): JDK-8148315 Create a basic reproducer for JDI issues

2016-01-27 Thread Dmitry Samersoff
Roger, If a test need multiple processes, parent process have to control its child. I.e. parent process have to know when child is ready to do some work, parent process should have a way to terminate child etc. Current tests uses different methods to control child process and not all of them work

Re: JDK-8031753 : Review request

2016-01-27 Thread Jaroslav Bachorik
Hi Harsha, On 27.1.2016 15:30, Harsha Wardhana B wrote: Hi Jaroslav, Below is the updated webrev with minor line alignment fixes. http://cr.openjdk.java.net/~hb/8031753/webrev.01/ The issue can be reproduced by removing entry for hostname

Re: RFR(S, TESTONLY): JDK-8148315 Create a basic reproducer for JDI issues

2016-01-27 Thread Dmitry Samersoff
Staffan, On 2016-01-27 17:09, Staffan Larsen wrote: > Have you looked at the com/sun/jdi test framework? The java framework > is quite good and stable. The shell script framework should be > removed. Are you speaking about TestScaffold? - Yes, I tried to adopt it first. Despite the fact that Tes

Re: JDK-8031753 : Review request

2016-01-27 Thread Harsha Wardhana B
Hi Jaroslav, Below is the updated webrev with minor line alignment fixes. http://cr.openjdk.java.net/~hb/8031753/webrev.01/ The issue can be reproduced by removing entry for hostname in /etc/hosts (for linux) and running 'javax/management/

Re: RFR(S, TESTONLY): JDK-8148315 Create a basic reproducer for JDI issues

2016-01-27 Thread Roger Riggs
As an alternative to a specific child application would it be possible / reasonable to use jshell as the child? Or use the jshell API to manage the child? Then you can feed it any java expressions/functions that are interesting and get back any data needed. $.02, Roger On 1/27/2016 9:09 A

Re: RFR(S, TESTONLY): JDK-8148315 Create a basic reproducer for JDI issues

2016-01-27 Thread Staffan Larsen
Have you looked at the com/sun/jdi test framework? The java framework is quite good and stable. The shell script framework should be removed. /Staffan > On 27 jan. 2016, at 13:02, Dmitry Samersoff > wrote: > > Staffan, > > 1. This is one more small step forward to remove wide variety of > Ex

Re: RFR(S, TESTONLY): JDK-8148315 Create a basic reproducer for JDI issues

2016-01-27 Thread Dmitry Samersoff
Staffan, 1. This is one more small step forward to remove wide variety of Exit0.java (and similar) programs from jdk tests. I will not happen today, but I hope, sometimes in a future, all tests that launch a child process will do it the same way. 2. We have couple of old SA-JDI tests in jdk.hots

Re: JDK-8031753 : Review request

2016-01-27 Thread Jaroslav Bachorik
Hi Harsha, On 27.1.2016 11:09, Harsha Wardhana B wrote: Hello All, For the below fix, I have made appropriate javadoc changes and uploaded new webrev at below location. http://cr.openjdk.java.net/~hb/8031753/webrev.00/ Please review and le

Re: JDK-8031753 : Review request

2016-01-27 Thread Harsha Wardhana B
Hello All, For the below fix, I have made appropriate javadoc changes and uploaded new webrev at below location. http://cr.openjdk.java.net/~hb/8031753/webrev.00/ Please review and let me know your comments. Thanks Harsha On Thursday 1

Re: RFR: 8147348: LogTagLevelExpression not properly initialized in configure_stdout

2016-01-27 Thread Marcus Larsson
Thanks Staffan! Marcus On 01/27/2016 08:56 AM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 21 jan. 2016, at 11:42, Marcus Larsson wrote: Hi, Please review the following patch to fix an initialization error in LogTagLevelExpression. If not using the parse() method (as is the cas