Re: Unused code in prims/methodComparator

Suspected that. :) Nice archeology! Thanks, Serguei On 2/5/16 06:26, Daniel D. Daugherty wrote: MethodComparator::methods_switchable() appears to be a day zero function added by Misha Dmitriev back on 2000.10.23. $ sgv src/share/vm/prims/methodComparator.cpp | grep

Re: Unused code in prims/methodComparator

On 5/02/2016 1:30 PM, serguei.spit...@oracle.com wrote: Hi Thomas, The function MethodComparator::methods_switchable() was not used even in the jdk 7. I couldn't find it used in 5 or 6 either! :) David I do not know the history of this function and why its usage was dropped. Most likely,

Re: Unused code in prims/methodComparator

Thanks, David! Serguei On 2/5/16 00:05, David Holmes wrote: On 5/02/2016 1:30 PM, serguei.spit...@oracle.com wrote: Hi Thomas, The function MethodComparator::methods_switchable() was not used even in the jdk 7. I couldn't find it used in 5 or 6 either! :) David I do not know the history

Re: Unused code in prims/methodComparator

On Fri, Feb 5, 2016 at 9:05 AM, David Holmes wrote: > On 5/02/2016 1:30 PM, serguei.spit...@oracle.com wrote: > >> Hi Thomas, >> >> The function MethodComparator::methods_switchable() was not used even in >> the jdk 7. >> > > I couldn't find it used in 5 or 6 either! :)

RFR (S): 8149112: configure_stdout test depends on VM arguments

Hi, Please review the following patch to make the configure_stdout internalvmtest independent on VM arguments for UL. Without this fix the test fails if run while logging to a file (-Xlog::somefile). Webrev: http://cr.openjdk.java.net/~mlarsson/8149112/webrev.00/ Issue:

Fwd: RFR:8147847: (re-review) serviceability/tmtools/jstat tests are failing with -XX:+ExplicitGCInvokesConcurrent

Hi, Could I, please, have any feedback on this trivial tests-only review? Best regards, Alexander - Forwarded Message - From: alexander.kulyakh...@oracle.com To: serviceability-dev@openjdk.java.net Sent: Wednesday, February 3, 2016 2:21:44 PM GMT +03:00 Iraq Subject: RFR:8147847:

Re: RFR (S): 8149112: configure_stdout test depends on VM arguments

On 2016-02-05, Marcus Larsson wrote: > Hi, > > Please review the following patch to make the configure_stdout > internalvmtest independent on VM arguments for UL. Without this fix the test > fails if run while logging to a file (-Xlog::somefile). > > Webrev: >

Re: RFR(XS): JDK-8149099 jcmd -help mention non-existent option

On 5.2.2016 11:53, Dmitry Samersoff wrote: Everybody, Please, review typo fix provided by Kubota Yuji http://cr.openjdk.java.net/~dsamersoff/sponsorship/kubota.yuji/JDK-8149099/webrev.01/ Looks good! -JB- -Dmitry

Re: Fwd: RFR:8147847: (re-review) serviceability/tmtools/jstat tests are failing with -XX:+ExplicitGCInvokesConcurrent

On 5.2.2016 13:14, Alexander Kulyakhtin wrote: Hi, Could I, please, have any feedback on this trivial tests-only review? Thumbs up! -JB- Best regards, Alexander - Forwarded Message - From: alexander.kulyakh...@oracle.com To: serviceability-dev@openjdk.java.net Sent: Wednesday,

Re: RFR:8147847: (re-review) serviceability/tmtools/jstat tests are failing with -XX:+ExplicitGCInvokesConcurrent

Looks good! Thanks, /Staffan > On 5 feb. 2016, at 13:14, Alexander Kulyakhtin > wrote: > > Hi, > > Could I, please, have any feedback on this trivial tests-only review? > > Best regards, > Alexander > > - Forwarded Message - > From:

RFR(XS): JDK-8149099 jcmd -help mention non-existent option

Everybody, Please, review typo fix provided by Kubota Yuji http://cr.openjdk.java.net/~dsamersoff/sponsorship/kubota.yuji/JDK-8149099/webrev.01/ -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the

Re: Unused code in prims/methodComparator

MethodComparator::methods_switchable() appears to be a day zero function added by Misha Dmitriev back on 2000.10.23. $ sgv src/share/vm/prims/methodComparator.cpp | grep MethodComparator::methods_switchable 1.17 1.1 bool MethodComparator::methods_switchable(methodOop old_method,

Re: RFR(XS): JDK-8149099 jcmd -help mention non-existent option

Hi Dmitry, Jaroslav Many thanks again for your sponsor and review! http://hg.openjdk.java.net/jdk9/hs-rt/jdk/rev/fb55d8342279 Yuji 2016-02-05 22:27 GMT+09:00 Jaroslav Bachorik : > On 5.2.2016 11:53, Dmitry Samersoff wrote: >> >> Everybody, >> >> Please, review