Re: [PING] Re: RFR (S): 8149112: configure_stdout test depends on VM arguments

2016-02-09 Thread Robbin Ehn
Looks good! /Robbin On 02/09/2016 10:33 AM, Marcus Larsson wrote: On 02/05/2016 01:07 PM, Marcus Larsson wrote: Hi, Please review the following patch to make the configure_stdout internalvmtest independent on VM arguments for UL. Without this fix the test fails if run while logging to a

[PING] Re: RFR (S): 8149112: configure_stdout test depends on VM arguments

2016-02-09 Thread Marcus Larsson
On 02/05/2016 01:07 PM, Marcus Larsson wrote: Hi, Please review the following patch to make the configure_stdout internalvmtest independent on VM arguments for UL. Without this fix the test fails if run while logging to a file (-Xlog::somefile). Webrev:

Re: RFR(xs): 8149096: Remove unused code in methodComparator

2016-02-09 Thread Thomas Stüfe
Hi all, thanks to all for your feedback. Here is the new webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8149096-remove-unused-code-methodComparator/webrev.01/webrev/index.html I removed _switchable_test and all code dependending from it. Thomas On Tue, Feb 9, 2016 at 7:17 AM,

Re: RFR : JDK-8147610 - javax/management/mxbean/MXBeanLoadingTest1.java assumes URLClassLoader

2016-02-09 Thread Chris Hegarty
On 09/02/16 06:30, Harsha Wardhana B wrote: Hi All, I request you to review fix for, Issue : JDK-8147610 - javax/management/mxbean/MXBeanLoadingTest1.java assumes URLClassLoader Webrev : http://cr.openjdk.java.net/~hb/8147610/werev.00/ I will leave it to others to comment on the specifics

Re: [PING] Re: RFR (S): 8149112: configure_stdout test depends on VM arguments

2016-02-09 Thread Jaroslav Bachorik
Looks good! -JB- On 9.2.2016 10:33, Marcus Larsson wrote: On 02/05/2016 01:07 PM, Marcus Larsson wrote: Hi, Please review the following patch to make the configure_stdout internalvmtest independent on VM arguments for UL. Without this fix the test fails if run while logging to a file

Re: RFR : JDK-8147610 - javax/management/mxbean/MXBeanLoadingTest1.java assumes URLClassLoader

2016-02-09 Thread Harsha Wardhana B
Thanks Chris for verifying the fix on jigsaw/jake. -Harsha On Tuesday 09 February 2016 05:57 PM, Chris Hegarty wrote: On 09/02/16 06:30, Harsha Wardhana B wrote: Hi All, I request you to review fix for, Issue : JDK-8147610 - javax/management/mxbean/MXBeanLoadingTest1.java assumes

[PATCH] 8145278: Fix memory leak in splitPathList

2016-02-09 Thread Alex Henrie
# HG changeset patch # User Alex Henrie # Date 1447827030 25200 # Tue Nov 17 23:10:30 2015 -0700 # Node ID 66ac6f9c95653631b99b69d97a45cbbd82684778 # Parent ab2ab8a6f54c9f2591fe3b035b5b09d5ada66106 8145278: Fix memory leak in splitPathList diff --git