Re: Fwd: Re: [8u] RFR: 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

2016-02-16 Thread Andreas Eriksson
Hi, Anyone with 8u Reviewer status who can take a look? - Andreas On 2016-02-10 19:01, Andreas Eriksson wrote: [Adding jdk8u-dev list] Hi, I believe I need an 8u Reviewer as well, since Dmitry is only committer for 8u? Could someone please take a look? This is type cleanup for dumping a

Re: RFR: 8144732: VM_HeapDumper hits assert with bad dump_len

2016-02-16 Thread Andreas Eriksson
Hi, New webrev with support for non-segmented dumps removed: http://cr.openjdk.java.net/~aeriksso/8144732/webrev.01/ I changed calculate_array_max_length a bit (in addition to removing the is_segmented check), to avoid a type underflow that could happen. On 2016-02-08 15:40, Dmitry Samersoff

Re: jmx-dev [ping] Re: RFR 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials (Round 2)

2016-02-16 Thread Daniel Fuchs
Hi Jaroslav, I have no objection to this change. Could you add a comment somewhere to explain how you generated the truststore and keystore - in case we need to tweak that again in the future? best regards, -- daniel On 16/02/16 10:41, Jaroslav Bachorik wrote: On 11.2.2016 11:39, Jaroslav Ba

[ping] Re: RFR 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials (Round 2)

2016-02-16 Thread Jaroslav Bachorik
On 11.2.2016 11:39, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8145919 Webrev: http://cr.openjdk.java.net/~jbachorik/8145919/webrev.02 The previous attempt to fix this problem was focused on the fact that the test tend to f