Re: G1 STW phases and FGC column in jstat

Hi, Would adopting MiGC (minor) and MaGC (major) in jstat output make more sense to cover all collectors' algorithms if we need a change here? Thanks. Tao Mao On Tue, Mar 1, 2016 at 3:03 PM, Yasumasa Suenaga wrote: > Hi Kirk, > > It is also incorrect to count initial mark

Re: G1 STW phases and FGC column in jstat

Hi Kirk, It is also incorrect to count initial mark and remark in CMS as a FGC. Though, how can we check execution of major collection without GC log? Should we add new PerfCounter for CGC (and add CGC column to jstat output)? Yasumasa On 2016/03/02 6:35, k...@kodewerk.com wrote: Hi, I

Re: G1 STW phases and FGC column in jstat

Hi, I think it is incorrect to count remark and cleanup as FGC. They are not full collections. It is also incorrect to count initial mark and remark in CMS as a FGC. It is unfortunate that this is counted this way. Regards, Kirk > On Mar 1, 2016, at 8:56 AM, Yasumasa Suenaga

G1 STW phases and FGC column in jstat

Hi all, I wonder that STW phases (Remark and Cleanup) at G1 are not counted in jstat FGC column. For example, Initial Mark and Remark at CMS are counted as FGC. For consistency, I think that G1 STW phases should be counted as FGC. What do you think about it? If it is accepted, I will file it

Re: RFR: 8146879: Add option for handling existing log files in UL

Hi Dmitry, Thanks for reviewing, but I'm withdrawing the current patch since I might choose to solve it in a different way. Sorry about that. Marcus On 03/01/2016 02:32 PM, Dmitry Samersoff wrote: Marcus, logFileOutput.cpp: 77: Please move this function to include file 149: you have to

Re: RFR: 8146879: Add option for handling existing log files in UL

Hi, After some offline discussions I'm withdrawing this patch. I will instead investigate if I can achieve similar behavior using log rotation as the default. Thanks, Marcus On 03/01/2016 12:11 PM, Marcus Larsson wrote: Hi again, Taking a different approach to this. New webrev:

Re: RFR: 8146879: Add option for handling existing log files in UL

Marcus, logFileOutput.cpp: 77: Please move this function to include file 149: you have to check that file is a regular one, before any attempt to rotate. Please, move this function to include file. 164: As soon as size_t can't represent more than 10 decimal digits, please replace

Re: RFR: 8146879: Add option for handling existing log files in UL (was: Truncate new UL log files)

Hi again, Taking a different approach to this. New webrev: http://cr.openjdk.java.net/~mlarsson/8146879/webrev.01/ Existing files will now by default be renamed/archived with a .X suffix where X is the lowest number such that the resulting file name is available (jvm.log becomes jvm.log.0).