Please review this small fix to some tests with the wrong paths in them. Tested
locally with jtreg 4.1 b12 and b13.
Thanks,
/Staffan
$ hg diff
diff --git a/test/gc/g1/plab/TestPLABPromotion.java
b/test/gc/g1/plab/TestPLABPromotion.java
--- a/test/gc/g1/plab/TestPLABPromotion.java
+++ b/test/gc
Hi Staffan,
Changes look good.
However it looks like this test has the same issue, right?
http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/file/59d3a69564dc/test/gc/g1/plab/TestPLABResize.java
It is currently ignored, but we should probably fix it too...
Thanks,
Bengt
On 2016-03-09 10:47, Staff
Good catch. Incremental change:
diff --git a/test/gc/g1/plab/TestPLABResize.java
b/test/gc/g1/plab/TestPLABResize.java
--- a/test/gc/g1/plab/TestPLABResize.java
+++ b/test/gc/g1/plab/TestPLABResize.java
@@ -27,7 +27,7 @@
* @summary Test for PLAB resizing
* @requires vm.gc=="G1" | vm.gc=="null
Great! Looks good now!
Bengt
On 2016-03-09 11:02, Staffan Larsen wrote:
Good catch. Incremental change:
diff --git a/test/gc/g1/plab/TestPLABResize.java
b/test/gc/g1/plab/TestPLABResize.java
--- a/test/gc/g1/plab/TestPLABResize.java
+++ b/test/gc/g1/plab/TestPLABResize.java
@@ -27,7 +27,7 @@
Hi Staffan,
Looks good, thanks for fixing this.
Thanks,
Christian
-Original Message-
From: serviceability-dev
[mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Staffan
Larsen
Sent: Wednesday, March 9, 2016 5:03 AM
To: Bengt Rutisson
Cc: serviceability-dev@openjdk.java.ne
Hi all,
I see the change is already pushed, but I am not sure this works as
intended:
We iterate now over all fully read items:
+ p = (prmap_t *)mbuff;
+ for(int i = 0; i < nmap; i++){
+if (p->pr_vaddr == 0x0) {
+
+}
+p = (prmap_t *)(mbuff + sizeof(prmap_
Christian, Bengt: Thanks for the reviews. Pushing now.
> On 9 mars 2016, at 11:29, Christian Tornqvist
> wrote:
>
> Hi Staffan,
>
> Looks good, thanks for fixing this.
>
> Thanks,
> Christian
>
> -Original Message-
> From: serviceability-dev
> [mailto:serviceability-dev-boun...@openj
Hi Thomas,
Thanks for identifying the issue. I will file a new bug for this and correct
the issue.
Regards,
Cheleswer
From: Thomas Stüfe [mailto:thomas.stu...@gmail.com]
Sent: Wednesday, March 09, 2016 4:44 PM
To: David Holmes
Cc: Kevin Walls; Cheleswer Sahu; Daniel Daugherty;
Hi,
> The jdk changes look good to me.
Thanks! Staffan
Jon,
>> Meaning, without the jdk changes, will jstat continue to work
>> as it currently does?
I uploaded new webrev. I updated webrev for hotspot only:
http://cr.openjdk.java.net/~ysuenaga/JDK-6291341/poc-2/hotspot/
This patch works
