RFR (S): 8137165: Tests fail in SR_Handler because thread is not VMThread or JavaThread

2016-03-13 Thread David Holmes
Bug: https://bugs.openjdk.java.net/browse/JDK-8137165 Webrev: http://cr.openjdk.java.net/~dholmes/8137165/webrev/ This isn't a fix per-se but some additional diagnostic code to try and detect the conditions where the bug might manifest. The basic failure mode was: # Internal Error (/opt/jprt

Re: Check core dumping is enabled when set CrashOnOutOfMemoryError

2016-03-13 Thread KUBOTA Yuji
Thanks David for looking and comments, 2016-03-14 9:25 GMT+09:00 David Holmes : > First I'm not convinced that you necessarily want to enable core dumps just > because you want to crash on OOM. Yes, that's right. I just want to avoid the failed of core dumping when we want it clearly by setting o

Re: RFR: JDK-8151709: jhsdb should show help message in SALauncher.

2016-03-13 Thread Yasumasa Suenaga
Hi Dmitry, I changed for arguments processing in jhsdb in new webrev: hotspot: http://cr.openjdk.java.net/~ysuenaga/JDK-8151709/webrev.02/hotspot/ jdk: http://cr.openjdk.java.net/~ysuenaga/JDK-8151709/webrev.02/jdk/ I encountered ArrayIndexOutOfBoundsException when I ran `jhsdb jstack

Re: RFR[9u-dev]: 8151509: In check_addr0() function pointer is not updated correctly

2016-03-13 Thread David Holmes
PS. Copyright year needs updating. David On 11/03/2016 9:38 PM, Cheleswer Sahu wrote: Thanks Dmitry and Thomas for reviews. After adding space I will request for the push. Regards, Cheleswer From: Dmitry Dmitriev Sent: Friday, March 11, 2016 5:00 PM To: Cheleswer Sahu; Thomas Stüfe Cc:

Re: RFR[9u-dev]: 8151509: In check_addr0() function pointer is not updated correctly

2016-03-13 Thread David Holmes
On 11/03/2016 9:38 PM, Cheleswer Sahu wrote: Thanks Dmitry and Thomas for reviews. After adding space I will request for the push. Consider this Reviewed. But this needs to pushed to hs-rt and currently the webrev is against jdk9/dev. Thanks, David Regards, Cheleswer From: Dmitry

Re: RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

2016-03-13 Thread David Holmes
Hi Erik, On 12/03/2016 2:31 AM, Erik Joelsson wrote: Hello, When building hotspot with closed sources present and configuring with --enable-openjdk-only, various closed parts are included in the build anyway, at least on Windows. This needs to be fixed in preparation for the new hotspot build f

Re: Check core dumping is enabled when set CrashOnOutOfMemoryError

2016-03-13 Thread David Holmes
Hi, On 13/03/2016 12:46 AM, KUBOTA Yuji wrote: Hi everyone. When set -XX:+CrashOnOutOfMemoryError, I think we should know whether core dumping has been enabled or not before launching process to prevent lack of information for after-the-fact analysis. First I'm not convinced that you necessar

Re: RFR: JDK-8151709: jhsdb should show help message in SALauncher.

2016-03-13 Thread Dmitry Samersoff
Yasumasa, 1. We shouldn't introduce dependency from Tool.java back to SALuancher. So please, change runJSTACK (and other similar functions) to catch invalid arguments. It might require changing of SAGetopt.java and/or jdk/test/sun/tools/jhsdb/SAGetoptTest.java 2. For JInfo changes, please crea

Re: RFR: 8146879: Add option for handling existing log files in UL

2016-03-13 Thread Dmitry Samersoff
Marcus, 1. os_posix/os_windows.cpp Windows version is expensive and change access time of a log file. So it's better to create os::get_mtime() that uses stat() for both, windows and posix and LogFileOutput::calc_mtime_diff(). Also it saves a bit of compiler power unrolling loop. 2. log.cpp si