Re: RFR(s) 4858370: JDWP: Memory Leak: GlobalRefs never deleted when processing invokeMethod command

Hi Serguei, On Mon, 2016-03-21 at 14:38 -0700, serguei.spit...@oracle.com wrote: > Hi Severin, > > Thank you for taking care about this issue! > > The fix looks pretty good. Thanks for the quick review! > A couple of minor comments though. > > src/jdk.jdwp.agent/share/native/libjdwp/invoker.c

Re: RFR(s) 4858370: JDWP: Memory Leak: GlobalRefs never deleted when processing invokeMethod command

Hi Severin, It looks good to me. Thank you for the changes! I'll wait some time for any other review before the push. Thanks, Serguei On 3/22/16 02:54, Severin Gehwolf wrote: Hi Serguei, On Mon, 2016-03-21 at 14:38 -0700, serguei.spit...@oracle.com wrote: Hi Severin, Thank you for takin

RFR(S): JDK-8151444 JDP not working on some windows configurations

Everybody, Please review the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8151444/webrev.01/ Removed code attempts to set IP_MULTICAST_IF to enforce sending of JDP packets to all available interfaces. It doesn't work on some multi-homed windows configurations. Also fixed minor bug in testcas

PING: RFR: JDK-8151815: Could not parse core image with JSnap.

PING: Could you review it? Yasumasa 2016/03/14 23:39 "Yasumasa Suenaga" : > Hi all, > > When I use `jhsdb jsnap` to get PerfCounter from core images, I > encountered NPE: > - > Exception in thread "main" java.lang.NullPointerException > at sun.jvm.hotspot.tools.JSnap.run(JSnap

Re: RFR(xs): 8151993: Remove inclusion of inline.hpp in log.hpp

Hi Kim, On 03/22/2016 04:32 AM, Kim Barrett wrote: On Mar 21, 2016, at 12:34 PM, Robbin Ehn wrote: Hi all, please review this a somewhat bigger change-set. Updated with the feedback. New webrev: http://cr.openjdk.java.net/~rehn/8151993/v2/webrev/ Tested with jprt hotspot and I added 2 inter

PING: JDK-8148659: Add all option to JSnap

PING: Could you review it? Yasumasa 2016/03/15 23:31 "Yasumasa Suenaga" : > Hi all, > > I updated webrev to adapt to current repos. Could you review it? > > http://cr.openjdk.java.net/~ysuenaga/JDK-8148659/webrev.01/ > > > Thanks, > > Yasumasa > > > On 2016/03/03 23:46, Yasumasa Suenaga wrote

Re: RFR: 7153107 com/sun/jdi/InterruptHangTest.java fails in nightlies

Anyone up for a review of this change? > On 21 mars 2016, at 09:16, Staffan Larsen wrote: > > Hi, > > For a while we have had various timeout related problem in the JDI tests. The > root cause of this seems to be the Indy String Concatenation work which makes > stepping over the first string

Re: RFR(S): JDK-8151444 JDP not working on some windows configurations

Looks good! Thanks, /Staffan > On 22 mars 2016, at 12:51, Dmitry Samersoff > wrote: > > Everybody, > > Please review the fix: > > http://cr.openjdk.java.net/~dsamersoff/JDK-8151444/webrev.01/ > > Removed code attempts to set IP_MULTICAST_IF to enforce sending of JDP > packets to all availab

Re: RFR: 8146879: Add option for handling existing log files in UL

Hi Marcus, On 03/18/2016 02:04 PM, Marcus Larsson wrote: Updated patch after feedback. New webrev: http://cr.openjdk.java.net/~mlarsson/8146879/webrev.04/ Incremental: http://cr.openjdk.java.net/~mlarsson/8146879/webrev.03-04/ Tested with internal VM tests through RBT. Changes: * Rotation fi

RFR: JDK-8152435: (CL)HSDB should be started with no argument

HI all, After JDK-8151709, CLHSDB and HSDB cannot be started with no argument via jhsdb. CLHSDB and HSDB can attach process / core after starting. jhsdb should support it. I uploaded webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8152435/webrev.00/ This patch passed jtreg test sun/tools/j

Re: RFR: 8146879: Add option for handling existing log files in UL

Thanks for reviewing, Robbin! Marcus On 03/22/2016 03:24 PM, Robbin Ehn wrote: Hi Marcus, On 03/18/2016 02:04 PM, Marcus Larsson wrote: Updated patch after feedback. New webrev: http://cr.openjdk.java.net/~mlarsson/8146879/webrev.04/ Incremental: http://cr.openjdk.java.net/~mlarsson/8146879

Re: RFR: 7153107 com/sun/jdi/InterruptHangTest.java fails in nightlies

Hi Staffan, It looks good. One question though. I do not see that the timeout is increased in the com/sun/jdi/InterruptHangTest.java. It remains 20 sec as was before. + float timeoutFactor = Float.parseFloat(System.getProperty("test.timeout.factor", "1.0")); + long sleepSeconds = (long)(20

Re: PING: JDK-8148659: Add all option to JSnap

Yasumasa, Looks good for me. -Dmitry On 2016-03-22 15:27, Yasumasa Suenaga wrote: > PING: Could you review it? > > Yasumasa > > 2016/03/15 23:31 "Yasumasa Suenaga" >: > > Hi all, > > I updated webrev to adapt to current repos. Could you review it? > >

Re: RFR: 7153107 com/sun/jdi/InterruptHangTest.java fails in nightlies

On 3/22/16 11:09, Staffan Larsen wrote: On 22 mars 2016, at 18:15, serguei.spit...@oracle.com wrote: Hi Staffan, It looks good. One question though. I do not see that the timeout is increased in the com/sun/jdi/InterruptHangTest.java. It remains 20 sec

Re: RFR: 8146879: Add option for handling existing log files in UL

hi Marcus, Thank you for incorporating the feedback. The only remaining comment I have is about the “number_of_lines_with_substring_in_file()” function. As written, it resets the entire algorithm to the beginning of the file when it can not fit the current line, when I think the intention shou

Re: RFR: 7153107 com/sun/jdi/InterruptHangTest.java fails in nightlies

> On 22 mars 2016, at 18:15, serguei.spit...@oracle.com wrote: > > Hi Staffan, > > It looks good. > One question though. > > I do not see that the timeout is increased in the > com/sun/jdi/InterruptHangTest.java. > It remains 20 sec as was before. > > +float timeoutFactor

Re: RFR: 7153107 com/sun/jdi/InterruptHangTest.java fails in nightlies

Thanks Serguei! > On 22 mars 2016, at 19:10, serguei.spit...@oracle.com wrote: > > On 3/22/16 11:09, Staffan Larsen wrote: >> >>> On 22 mars 2016, at 18:15, >>> serguei.spit...@oracle.com >>> wrote: >>> >>> Hi Staffan, >>

Re: RFR(S): JDK-8151444 JDP not working on some windows configurations

Hi Dmitry, Does your change work on Linux multi-homed environment? The code which you remove is added at JDK-8057556. http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-September/015504.html DiagramChannel which is used in JDPBroadcaster tries to send JDP packet through all "UP" N