Re: RFR: 8151438: UL instantiates duplicate tag sets

Hi Marcus, On 23/03/16 11:59, Marcus Larsson wrote: Hi Stefan, On 03/23/2016 11:00 AM, Stefan Karlsson wrote: Hi Marcus, On 2016-03-23 10:23, Marcus Larsson wrote: Hi, Please review the following patch to fix the issue where duplicate tagsets are created for the same logical tagset. The

NEED REVIEWER Re: RFR(S): JDK-8151991 jvmti diagnostics commands requires INCLUDE_SERVICES

Everybody, Webrev updated according to David's concerns. http://cr.openjdk.java.net/~dsamersoff/JDK-8151991/webrev.02/ -Dmitry On 2016-03-18 07:42, David Holmes wrote: > On 17/03/2016 12:14 AM, Dmitry Samersoff wrote: >> Everybody, >> >> Please, review small fix. >> >> http://cr.openjdk.java.ne

Re: RFR: 8151438: UL instantiates duplicate tag sets

Thanks for reviewing, Bengt! Marcus On 03/23/2016 01:36 PM, Bengt Rutisson wrote: Hi Marcus, Looks good to me. Thanks, Bengt On 2016-03-23 11:59, Marcus Larsson wrote: Hi Stefan, On 03/23/2016 11:00 AM, Stefan Karlsson wrote: Hi Marcus, On 2016-03-23 10:23, Marcus Larsson wrote: Hi, P

Re: RFR(xs): 8151993: Remove inclusion of inline.hpp in log.hpp (v4)

Hi Stefan On 03/23/2016 03:27 PM, Stefan Karlsson wrote: Hi Robbin, On 2016-03-23 14:50, Robbin Ehn wrote: Hi all, After more input, this is the current version. Please have a look. Webrev: http://cr.openjdk.java.net/~rehn/8151993/v4/webrev/ Incremental: http://cr.openjdk.java.net/~rehn/8151

Re: RFR(xs): 8151993: Remove inclusion of inline.hpp in log.hpp (v4)

Hi Robbin, On 2016-03-23 14:50, Robbin Ehn wrote: Hi all, After more input, this is the current version. Please have a look. Webrev: http://cr.openjdk.java.net/~rehn/8151993/v4/webrev/ Incremental: http://cr.openjdk.java.net/~rehn/8151993/v3-v4/ Looks good to me. It's non-obvious why you ch

Re: RFR(xs): 8151993: Remove inclusion of inline.hpp in log.hpp (v4)

Hi all, After more input, this is the current version. Please have a look. Webrev: http://cr.openjdk.java.net/~rehn/8151993/v4/webrev/ Incremental: http://cr.openjdk.java.net/~rehn/8151993/v3-v4/ Thanks! /Robbin On 03/21/2016 05:34 PM, Robbin Ehn wrote: Hi all, please review this a somewhat

PING: RFR: JDK-8151674: STW phases at Concurrent GC should count in PerfCounter

PING: We need one more reviewer for HotSpot changes. Please review. Thanks, Yasumasa On 2016/03/19 4:45, Jon Masamitsu wrote: On 3/18/2016 7:14 AM, Yasumasa Suenaga wrote: Hi, I added a comment to JBS about G1 initial mark. I will upload new webrev after discussing for it. We discuss

Re: RFR(S): JDK-8151444 JDP not working on some windows configurations

Dmitry, Thanks, I understood. I have no objection. Yasumasa On 2016/03/23 20:51, Dmitry Samersoff wrote: > Yasumasa, > >We have at least two problems with explicit setting of IP_MULTICAST_IF > that I can reproduce in-house.[1] > >Source address of IP packet should match the interface

Re: RFR: 8152538: UL doesn't inline the LogTagSet::is_level check

Hi StefanK, Looks good! Bengt On 2016-03-23 11:28, Stefan Karlsson wrote: Hi all, Please, review this patch to optimize the log_is_enabled check in the Unified Logging framework. http://cr.openjdk.java.net/~stefank/8152538/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8152538 The f

Re: RFR: 8151438: UL instantiates duplicate tag sets

Hi Marcus, Looks good to me. Thanks, Bengt On 2016-03-23 11:59, Marcus Larsson wrote: Hi Stefan, On 03/23/2016 11:00 AM, Stefan Karlsson wrote: Hi Marcus, On 2016-03-23 10:23, Marcus Larsson wrote: Hi, Please review the following patch to fix the issue where duplicate tagsets are create

Re: RFR(S): JDK-8151444 JDP not working on some windows configurations

Yasumasa, We have at least two problems with explicit setting of IP_MULTICAST_IF that I can reproduce in-house.[1] Source address of IP packet should match the interface we are using and network configuration can be changed while Java app is running i.e. after the point we are setting interfa

Re: RFR: 8151438: UL instantiates duplicate tag sets

Hi Stefan, On 03/23/2016 11:00 AM, Stefan Karlsson wrote: Hi Marcus, On 2016-03-23 10:23, Marcus Larsson wrote: Hi, Please review the following patch to fix the issue where duplicate tagsets are created for the same logical tagset. The code that emulates the variadic template arguments ass

Re: RFR: 8152538: UL doesn't inline the LogTagSet::is_level check

Hi Stefan, On 03/23/2016 11:28 AM, Stefan Karlsson wrote: Hi all, Please, review this patch to optimize the log_is_enabled check in the Unified Logging framework. http://cr.openjdk.java.net/~stefank/8152538/webrev.01/ Looks good, thanks for fixing this! Marcus https://bugs.openjdk.java.

PING: Re: RFR: 8150823: UL handles disabling logs incorrectly

On 03/18/2016 12:25 PM, Marcus Larsson wrote: Hi, Updated the patch after offline discussion. New patch attempts to normalize the output name before searching for it or adding it. This includes adding the implicit file= prefix if missing, and/or removing quotes from a quoted name. Webrev: h

RFR: 8152538: UL doesn't inline the LogTagSet::is_level check

Hi all, Please, review this patch to optimize the log_is_enabled check in the Unified Logging framework. http://cr.openjdk.java.net/~stefank/8152538/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8152538 The following code: void logLine() { log_debug(gc)("logLine"); } expands in

Re: RFR: 8151438: UL instantiates duplicate tag sets

Hi Marcus, On 2016-03-23 10:23, Marcus Larsson wrote: Hi, Please review the following patch to fix the issue where duplicate tagsets are created for the same logical tagset. The code that emulates the variadic template arguments assumes that _NO_TAG terminates the sequence of tags. If other

RFR: 8151438: UL instantiates duplicate tag sets

Hi, Please review the following patch to fix the issue where duplicate tagsets are created for the same logical tagset. The code that emulates the variadic template arguments assumes that _NO_TAG terminates the sequence of tags. If other tags (other than _NO_TAG) follow a terminating tag, te