Re: NEED REVIEWER Re: RFR(S): JDK-8151991 jvmti diagnostics commands requires INCLUDE_SERVICES

Hi Dmitry, -#if INCLUDE_SERVICES // Heap dumping/inspection supported +#if INCLUDE_SERVICES DCmdFactory::register_DCmdFactory(new DCmdFactoryImpl(DCmd_Source_Internal | DCmd_Source_AttachAPI, true, false)); DCmdFactory::register_DCmdFactory(new DCmdFactoryImpl(full_export, true, false));

RFR: 8147987: Remove sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java from problemList

Hi, Could you, please, review this trivial, test-only change (enabling a previously excluded test) Webrev: http://cr.openjdk.java.net/~akulyakh/8147987/test/ProblemList.txt.udiff.html CR: https://bugs.openjdk.java.net/browse/JDK-8147987 "Remove sun/management/jmxremote/bootstrap/JMXInterfaceBi

Re: NEED REVIEWER Re: RFR(S): JDK-8151991 jvmti diagnostics commands requires INCLUDE_SERVICES

Serguei, Webrev updated in-place (press shift-reload): http://cr.openjdk.java.net/~dsamersoff/JDK-8151991/webrev.02/ -Dmitry On 2016-03-24 12:22, serguei.spit...@oracle.com wrote: > Hi Dmitry, > > -#if INCLUDE_SERVICES // Heap dumping/inspection supported > +#if INCLUDE_SERVICES >DCmdFact

Re: NEED REVIEWER Re: RFR(S): JDK-8151991 jvmti diagnostics commands requires INCLUDE_SERVICES

Looks good. Thanks! Serguei On 3/24/16 04:48, Dmitry Samersoff wrote: Serguei, Webrev updated in-place (press shift-reload): http://cr.openjdk.java.net/~dsamersoff/JDK-8151991/webrev.02/ -Dmitry On 2016-03-24 12:22, serguei.spit...@oracle.com wrote: Hi Dmitry, -#if INCLUDE_SERVICES // H

Re: RFR: 8147987: Remove sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java from problemList

Hi Alexander, Looks good. Thanks, Serguei On 3/24/16 04:46, Alexander Kulyakhtin wrote: Hi, Could you, please, review this trivial, test-only change (enabling a previously excluded test) Webrev: http://cr.openjdk.java.net/~akulyakh/8147987/test/ProblemList.txt.udiff.html CR: https://bugs.

RFR (xs) 8152719: ignore com/sun/jdi/InterfaceMethodsTest.java until bug is fixed

open webrev at http://cr.openjdk.java.net/~coleenp/8152719/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8152719 Thanks, Coleen

Re: RFR (xs) 8152719: ignore com/sun/jdi/InterfaceMethodsTest.java until bug is fixed

Thanks for the reviews from Christian and Harold. Posting to serviceability-dev also. Coleen On 3/24/16 3:26 PM, Coleen Phillimore wrote: Well, I'm told this isn't the right way to do this. It should be added to the ProblemList.txt file. open webrev at http://cr.openjdk.java.net/~coleenp/

Re: RFR (xs) 8152719: ignore com/sun/jdi/InterfaceMethodsTest.java until bug is fixed

Good. Thanks, Serguei On 3/24/16 12:14, Coleen Phillimore wrote: open webrev at http://cr.openjdk.java.net/~coleenp/8152719/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8152719 Thanks, Coleen

Re: RFR (xs) 8152719: ignore com/sun/jdi/InterfaceMethodsTest.java until bug is fixed

thanks! coleen On 3/24/16 3:55 PM, serguei.spit...@oracle.com wrote: Good. Thanks, Serguei On 3/24/16 12:14, Coleen Phillimore wrote: open webrev at http://cr.openjdk.java.net/~coleenp/8152719/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8152719 Thanks, Coleen

Re: RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater than 1996 characters

Hi I didn't think of %.s when Cheleswer and I discussed this briefly. I'd like to have suggested that, with the idea that the 2k long thread name is extreme, and it's so important that we preserve the format of the output, and keep that closing quote, even if we lost some of the thread

Re: RFR(xs): 8151993: Remove inclusion of inline.hpp in log.hpp (v4)

> On Mar 23, 2016, at 9:50 AM, Robbin Ehn wrote: > > Hi all, > > After more input, this is the current version. > Please have a look. > > Webrev: http://cr.openjdk.java.net/~rehn/8151993/v4/webrev/ > Incremental: http://cr.openjdk.java.net/~rehn/8151993/v3-v4/ This looks good.