Re: RFR(xs): 8151993: Remove inclusion of inline.hpp in log.hpp (v4)

2016-03-29 Thread Robbin Ehn
Thanks Kim! /Robbin On 03/24/2016 09:14 PM, Kim Barrett wrote: On Mar 23, 2016, at 9:50 AM, Robbin Ehn wrote: Hi all, After more input, this is the current version. Please have a look. Webrev: http://cr.openjdk.java.net/~rehn/8151993/v4/webrev/ Incremental: http://cr.openjdk.java.net/~rehn/

Re: RFR: 8151438: UL instantiates duplicate tag sets

2016-03-29 Thread Marcus Larsson
Thanks for reviewing, Stefan! On 03/23/2016 08:34 PM, Stefan Karlsson wrote: Hi Marcus, On 23/03/16 11:59, Marcus Larsson wrote: Hi Stefan, On 03/23/2016 11:00 AM, Stefan Karlsson wrote: Hi Marcus, On 2016-03-23 10:23, Marcus Larsson wrote: Hi, Please review the following patch to fix th

Re: RFR(S) JDK-8150973 Hotspot agent use of sun.boot.class.path needs to be updated for Jigsaw

2016-03-29 Thread Dmitry Samersoff
Everybody, http://cr.openjdk.java.net/~dsamersoff/JDK-8150973/webrev.02/ Webrev updated (in-place, press shift-reload). VirtualMachineImpl.bootClassPath() returns Collections.emptyList() rather than throw an exception. -Dmitry On 2016-03-28 21:15, Dmitry Samersoff wrote: > Everybody, > > Ple

Re: RFR(S) JDK-8150973 Hotspot agent use of sun.boot.class.path needs to be updated for Jigsaw

2016-03-29 Thread Alan Bateman
On 29/03/2016 09:15, Dmitry Samersoff wrote: Everybody, http://cr.openjdk.java.net/~dsamersoff/JDK-8150973/webrev.02/ Webrev updated (in-place, press shift-reload). VirtualMachineImpl.bootClassPath() returns Collections.emptyList() rather than throw an exception. This looks okay except for

Re: RFR(S) JDK-8150973 Hotspot agent use of sun.boot.class.path needs to be updated for Jigsaw

2016-03-29 Thread Dmitry Samersoff
Alan, done (in-place) http://cr.openjdk.java.net/~dsamersoff/JDK-8150973/webrev.02/ -Dmitry On 2016-03-29 11:21, Alan Bateman wrote: > > > On 29/03/2016 09:15, Dmitry Samersoff wrote: >> Everybody, >> >> http://cr.openjdk.java.net/~dsamersoff/JDK-8150973/webrev.02/ >> >> Webrev updated (in-pl

Re: RFR(S) JDK-8150973 Hotspot agent use of sun.boot.class.path needs to be updated for Jigsaw

2016-03-29 Thread Alan Bateman
On 29/03/2016 09:54, Dmitry Samersoff wrote: Alan, done (in-place) http://cr.openjdk.java.net/~dsamersoff/JDK-8150973/webrev.02/ -Dmitry Looks okay to me. At some point (and nothing to do with this change) is that we should add type parameters to the other methods like getPath, classPath

Re: PING: RFR: JDK-8151815: Could not parse core image with JSnap.

2016-03-29 Thread Yasumasa Suenaga
PING: Could you review it? Yasumasa On 2016/03/22 21:24, Yasumasa Suenaga wrote: PING: Could you review it? Yasumasa 2016/03/14 23:39 "Yasumasa Suenaga" mailto:yasue...@gmail.com>>: Hi all, When I use `jhsdb jsnap` to get PerfCounter from core images, I encountered NPE: -

Re: RFR: JDK-8152435: (CL)HSDB should be started with no argument

2016-03-29 Thread Yasumasa Suenaga
PING: Could you review it? Yasumasa On 2016/03/22 23:49, Yasumasa Suenaga wrote: > HI all, > > After JDK-8151709, CLHSDB and HSDB cannot be started with no argument via > jhsdb. > CLHSDB and HSDB can attach process / core after starting. > jhsdb should support it. > > I uploaded webrev: > >