RFR(M): 8148195: Some InstanceKlass and MethodCounters fields can be excluded when JVMTI is not supported

Please review the following for removing some fields that are not needed when not supporting JVMTI. https://bugs.openjdk.java.net/browse/JDK-8148195 http://cr.openjdk.java.net/~cjplummer/8148195/webrev.02/webrev.hotspot/ I had passed a preliminary review around a month or so ago. The webrev is

Re: javaone 2012 presentation on Diagnosing Your Application on the JVM : Question on attach on Windows

> On 30 mars 2016, at 09:40, Bacchu, Anjan wrote: > > Hi Staffan, > > I just now saw the presentation slides at > http://www.slideshare.net/stalar/diagnosing-your-application-on-the-jvm > . > > On Slide 16 of th

RE: RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater than 1996 characters

Hi It seems there are two approaches here, either we truncate long thread names, or we make sure to print the full thread name. I agree with Dmitry and Kirk that if the API allows these long names, the tooling should do the right thing (even though one has to wonder what these long names are).

Re: RFR: 8146879: Add option for handling existing log files in UL

Look good. Thank you for you patience with my review. cheers > On Mar 30, 2016, at 9:17 AM, Marcus Larsson wrote: > > Hi Gerard, > > On 03/22/2016 07:15 PM, Gerard Ziemski wrote: >> hi Marcus, >> >> Thank you for incorporating the feedback. >> >> The only remaining comment I have is about

Re: RFR: 8146879: Add option for handling existing log files in UL

Hi Gerard, On 03/22/2016 07:15 PM, Gerard Ziemski wrote: hi Marcus, Thank you for incorporating the feedback. The only remaining comment I have is about the “number_of_lines_with_substring_in_file()” function. As written, it resets the entire algorithm to the beginning of the file when it ca

Re: RFR: JDK-8151674: STW phases at Concurrent GC should count in PerfCounter

Hi, On Fri, 2016-03-18 at 12:45 -0700, Jon Masamitsu wrote: > > On 3/18/2016 7:14 AM, Yasumasa Suenaga wrote: > > Hi, > > > > > I added a comment to JBS about G1 initial mark. > > > I will upload new webrev after discussing for it. > > > > We discussed about it on JBS, and we decided not to cou

Re: RFR(S) JDK-8150973 Hotspot agent use of sun.boot.class.path needs to be updated for Jigsaw

On 3/30/16 01:50, Dmitry Samersoff wrote: Serguei, Thank you for review! These tests are not part of any testing process. I plan to review and fix/delete it as necessary under a separate CR (JDK-8146200) Ok, reviewed. Thanks, Serguei -Dmitry On 2016-03-30 11:28, serguei.spit...@oracle.

Re: RFR(S) JDK-8150973 Hotspot agent use of sun.boot.class.path needs to be updated for Jigsaw

Serguei, Thank you for review! These tests are not part of any testing process. I plan to review and fix/delete it as necessary under a separate CR (JDK-8146200) -Dmitry On 2016-03-30 11:28, serguei.spit...@oracle.com wrote: > Hi Dmitry, > > Looks good in general. > > The following files in t

Re: RFR(S) JDK-8150973 Hotspot agent use of sun.boot.class.path needs to be updated for Jigsaw

Hi Dmitry, Looks good in general. The following files in the jdk.hotspot.agent/test folder may need to be updated too: src/jdk.hotspot.agent/test/jdi/runjdb.sh src/jdk.hotspot.agent/test/jdi/runsa.sh Thanks, Serguei On 3/29/16 02:41, Alan Bateman wrote: On 29/03/2016 09:54, Dmitry Sa

Re: PING: Re: RFR: 8150823: UL handles disabling logs incorrectly

Need a Reviewer for this. Thanks, Marcus On 03/23/2016 11:41 AM, Marcus Larsson wrote: On 03/18/2016 12:25 PM, Marcus Larsson wrote: Hi, Updated the patch after offline discussion. New patch attempts to normalize the output name before searching for it or adding it. This includes adding the