RFR 8150607 - Clean up CompactHashtable

Please review http://cr.openjdk.java.net/~iklam/jdk9/8150607_cleanup_compact_hashtable.v01/ Bug: Clean up CompactHashtable https://bugs.openjdk.java.net/browse/JDK-8150607 Summary of fix: [1] Instead of reading/writing the table bit-by-bit, which is tedious and error prone, use

Re: RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater than 1996 characters

Yes, looks good. 8-) On 31/03/2016 19:54, Dmitry Samersoff wrote: Cheleswer, Looks good for me! (R) -Dmitry On 2016-03-31 12:46, Cheleswer Sahu wrote: Hi , I would like to go with the "print_raw()" option as this can print any length of thread name. I have modified the code and written

Re: RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater than 1996 characters

Cheleswer, Looks good for me! (R) -Dmitry On 2016-03-31 12:46, Cheleswer Sahu wrote: > Hi , > > I would like to go with the "print_raw()" option as this can print any length > of thread name. I have modified the code and written a test case also for > this bug. Please review the code

Re: RFR(M): 8148195: Some InstanceKlass and MethodCounters fields can be excluded when JVMTI is not supported

Hi Serguei, Thanks for the review. I'll make all the changes you suggested. cheers, Chris On 3/31/16 12:38 AM, serguei.spit...@oracle.com wrote: Hi Chris, It looks pretty good, thanks!

javaone 2012 presentation on Diagnosing Your Application on the JVM : Question on attach on Windows

Hi Staffan, I just now saw the presentation slides at http://www.slideshare.net/stalar/diagnosing-your-application-on-the-jvm. On Slide 16 of the presentation, you show the details of the "HotSpot Dynamic Attach Mechanism" for Windows. 1) You talk about Remote process injecting code

RE: javaone 2012 presentation on Diagnosing Your Application on the JVM : Question on attach on Windows

Hi Staffan, Thank you very much for the presentation and the quick response. Jcmd/jmap : Unfortunately, we ship only the Client JRE with our product. Customer doesn’t have access to jcmd/jmap. That’s why I was looking for an outside solution. Then I came across

Re: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

CC'ed to serviceability-dev. Could you review it? >http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.00/ Thanks, Yasumasa On 2016/03/30 23:09, Yasumasa Suenaga wrote: > Hi all, > > This request review is related to [1]. > > I want to see output option (filecount, filesize) in

Re: RFR: JDK-8153073: UL: Set filesize option with k/m/g

CC'ed to serviceability-dev. Could you review it? >http://cr.openjdk.java.net/~ysuenaga/JDK-8153073/webrev.01/ Thanks, Yasumasa On 2016/03/31 18:24, Yasumasa Suenaga wrote: > Hi Marcus, > >> You're missing an include of arguments.hpp in logFileOutput.cpp. > > arguments.hpp is included

RFR (S): 8153174: Remove trailing comma from log configuration listings

Hi, Please review the following small patch to avoid adding a trailing comma in the tagset and level listings in the configuration string for log outputs. Removing this comma allows the string to be used without modification when configuring logging (with -Xlog or similar). Webrev:

RE: RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater than 1996 characters

Hi , I would like to go with the "print_raw()" option as this can print any length of thread name. I have modified the code and written a test case also for this bug. Please review the code changes from the below link http://cr.openjdk.java.net/~csahu/8151442/webrev.01/ Regards, Cheleswer

Re: RFR(M): 8148195: Some InstanceKlass and MethodCounters fields can be excluded when JVMTI is not supported

Hi Chris, It looks pretty good, thanks! Just some minor comments below. src/share/vm/ci/ciMethod.cpp The only file with old Copyright year. src/share/vm/oops/instanceKlass.hpp 907 // Breakpoint support (see methods on Method* for details) 908 #if INCLUDE_JVMTI 909 BreakpointInfo*

Re: RFR: 8146879: Add option for handling existing log files in UL

Thanks for reviewing! Marcus On 03/30/2016 06:16 PM, Gerard Ziemski wrote: Look good. Thank you for you patience with my review. cheers On Mar 30, 2016, at 9:17 AM, Marcus Larsson wrote: Hi Gerard, On 03/22/2016 07:15 PM, Gerard Ziemski wrote: hi Marcus,

RFR(M): 8148195: Some InstanceKlass and MethodCounters fields can be excluded when JVMTI is not supported

Please review the following for removing some fields that are not needed when not supporting JVMTI. https://bugs.openjdk.java.net/browse/JDK-8148195 http://cr.openjdk.java.net/~cjplummer/8148195/webrev.02/webrev.hotspot/ I had passed a preliminary review around a month or so ago. The webrev