Re: RFR 8150607 - Clean up CompactHashtable

2016-04-11 Thread Ioi Lam
Hi Jiangli, Thanks for the review: On 4/11/16 6:44 PM, Jiangli Zhou wrote: Hi Ioi, I like the more structural way of reading/writing the compact table with SimpleCompactHashtable. It looks quite clean overall. - How about using VALUE_ONLY_BUCKET_TYPE, which is more descriptive than

Re: RFR 8150607 - Clean up CompactHashtable

2016-04-11 Thread Jiangli Zhou
Hi Ioi, I like the more structural way of reading/writing the compact table with SimpleCompactHashtable. It looks quite clean overall. - How about using VALUE_ONLY_BUCKET_TYPE, which is more descriptive than TINY_BUCKET_TYPE? - The following assert in CompactSymbolTableWriter::add() limits

Re: RFR 8151546: nsk/jvmti/RedefineClasses/StressRedefine fails in hs nightly

2016-04-11 Thread serguei.spit...@oracle.com
Coleen, src/share/vm/prims/jvmtiRedefineClasses.cpp - // Update the version number of the constant pool + // Update the version number of the constant pools (may keep scratch_cp) merge_cp->increment_and_save_version(old_cp->version()); +

RFR 8151546: nsk/jvmti/RedefineClasses/StressRedefine fails in hs nightly

2016-04-11 Thread Coleen Phillimore
Summary: Constant pool merging is not thread safe for source_file_name. This change includes the change for the following bug because they are tested together. 8148772: VM crash in nsk/jvmti/RedefineClasses/StressRedefine: assert failed: Corrupted constant pool Summary:

RFR(8u) JDK-8153252: SA: Hotspot build on Windows fails if make/closed folder does not exist

2016-04-11 Thread Poonam Bajaj Parhar
Hello, Please review this simple fix. Bug JDK-8153252 : SA: Hotspot build on Windows fails if make/closed folder does not exist Problem: The problem is that the SA build on windows fails while building non-openjdk commercial sources that

PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

2016-04-11 Thread Yasumasa Suenaga
PING: Could you review and sponsor it? >> http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.00/ Thanks, Yasumasa On 2016/03/31 22:35, Yasumasa Suenaga wrote: > CC'ed to serviceability-dev. > > Could you review it? > >>

PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

2016-04-11 Thread Yasumasa Suenaga
PING: Could you review it? We need more reviewer. >> http://cr.openjdk.java.net/~ysuenaga/JDK-8153073/webrev.01/ Thanks, Yasumasa On 2016/03/31 22:33, Yasumasa Suenaga wrote: > CC'ed to serviceability-dev. > > Could you review it? > >>