Hi Yasumasa,
On 20/04/2016 7:15 PM, Yasumasa Suenaga wrote:
Hi David,
... on 32-bit size_t and julong are not the same size so we would
still need to ensure we don't specify a filesize that is greater than
SIZE_MAX on 32-bit.
Oh... I understood.
I've fixed and uploaded new webrev. Could you
Hi,
Could I have a review of this small fix that adds support for
experimental events and experimental fields for event based tracing.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8154794
Webrev:
http://cr.openjdk.java.net/~egahlin/8154794/
Thanks
Erik
Dmitry,
Thank you for the reply.
I hope, you run all the JDI tests including nsk.jdi and jtreg com/sun/jdi.
Reviewed.
Thanks,
Serguei
On 4/20/16 10:12, Dmitry Samersoff wrote:
Serguei,
The test fails rarely and I'm not able to reproduce the issue.
JDWP call
Serguei,
The test fails rarely and I'm not able to reproduce the issue.
JDWP call JvmtiGetLoadedClasses::getLoadedClasses then store received
classes locally.
So nothing prevent these classes from being unloaded and I think it's
worth to fix.
-Dmitry
On 2016-04-19 19:49,
Hi,
Could you, please, review this small tests-only fix:
CR: https://bugs.openjdk.java.net/browse/JDK-8153992 "Some SVC tests fail on
compact2 due to an unnecessary test library dependency"
Webrev:
Yasumasa,
I need some more time to check what is happening with performance
counters and what side effect this fix can have.
Sorry about it.
-Dmitry
On 2016-04-20 15:14, Yasumasa Suenaga wrote:
> PING: Could you review it?
>
>>http://cr.openjdk.java.net/~ysuenaga/JDK-8151815/webrev.02/
>
PING: Could you review it?
http://cr.openjdk.java.net/~ysuenaga/JDK-8151815/webrev.02/
This changes is based on jdk9/hs-rt.
But I confirmed this patch works fine on jdk9/hs .
Thanks,
Yasumasa
On 2016/04/13 22:22, Yasumasa Suenaga wrote:
Hi Dmitry,
Thank you for your comment.
I
Thanks Marcus!
/Robbin
On 04/20/2016 01:54 PM, Marcus Larsson wrote:
Hi,
On 04/20/2016 01:47 PM, Robbin Ehn wrote:
Hi all, please review!
print() method was changed in 8154041 to have outputStream argument,
this renames print to print_on.
Since JvmtiBreakpoint extends GrowableElement
Hi,
On 04/20/2016 01:47 PM, Robbin Ehn wrote:
Hi all, please review!
print() method was changed in 8154041 to have outputStream argument,
this renames print to print_on.
Since JvmtiBreakpoint extends GrowableElement print_on already exists
as a virtual const method, hence the const changes.
Hi all, please review!
print() method was changed in 8154041 to have outputStream argument,
this renames print to print_on.
Since JvmtiBreakpoint extends GrowableElement print_on already exists as
a virtual const method, hence the const changes.
Bug:
Hi David,
... on 32-bit size_t and julong are not the same size so we would still need to
ensure we don't specify a filesize that is greater than SIZE_MAX on 32-bit.
Oh... I understood.
I've fixed and uploaded new webrev. Could you review again?
On Tue, 2016-04-19 at 19:32 -0700, serguei.spit...@oracle.com wrote:
> On 4/19/16 19:06, serguei.spit...@oracle.com wrote:
> >
> > On 4/19/16 02:22, serguei.spit...@oracle.com wrote:
> > >
> > > On 4/19/16 02:16, Severin Gehwolf wrote:
> > > >
> > > > Hi,
> > > >
> > > > On Tue, 2016-04-19 at
Thanks Stefan!
And for sponsoring!
/Robbin
On 04/20/2016 10:00 AM, Stefan Karlsson wrote:
Hi Robbin,
This looks good to me. This breaks gc nightly and is a fairly trivial
change, so I'll push this right away.
Thanks,
StefanK
On 2016-04-20 09:40, Robbin Ehn wrote:
Hi all,
Please review.
Thanks David!
/Robbin
On 04/20/2016 09:57 AM, David Holmes wrote:
Looks fine to me.
Thanks,
David
On 20/04/2016 5:40 PM, Robbin Ehn wrote:
Hi all,
Please review.
We are missing a cr on a log stream, which leads to this guarantee.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154728
David,
The problem is observed under Aurora/Windows where the test starts
as C:\ but when JPS is run the path is E:\
So the test is failed.
I have no ideas how it happens.
-Dmitry
On 2016-04-20 05:37, David Holmes wrote:
> Hi Dmitry,
>
> On 19/04/2016 11:06 PM, Dmitry Samersoff wrote:
>>
Hi Robbin,
This looks good to me. This breaks gc nightly and is a fairly trivial
change, so I'll push this right away.
Thanks,
StefanK
On 2016-04-20 09:40, Robbin Ehn wrote:
Hi all,
Please review.
We are missing a cr on a log stream, which leads to this guarantee.
Bug:
Looks fine to me.
Thanks,
David
On 20/04/2016 5:40 PM, Robbin Ehn wrote:
Hi all,
Please review.
We are missing a cr on a log stream, which leads to this guarantee.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154728
Thanks !
/Robbin
diff -r 857efca82258
Thanks Mikael!
/Robbin
On 04/20/2016 09:51 AM, Mikael Gerdin wrote:
Hi Robbin,
On 2016-04-20 09:40, Robbin Ehn wrote:
Hi all,
Please review.
We are missing a cr on a log stream, which leads to this guarantee.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154728
Thanks !
/Robbin
diff
Hi Robbin,
On 2016-04-20 09:40, Robbin Ehn wrote:
Hi all,
Please review.
We are missing a cr on a log stream, which leads to this guarantee.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154728
Thanks !
/Robbin
diff -r 857efca82258 src/share/vm/prims/jvmtiExport.cpp
---
Hi all,
Please review.
We are missing a cr on a log stream, which leads to this guarantee.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154728
Thanks !
/Robbin
diff -r 857efca82258 src/share/vm/prims/jvmtiExport.cpp
--- a/src/share/vm/prims/jvmtiExport.cppSun Apr 17 19:15:52 2016
On 20/04/2016 3:25 PM, Yasumasa Suenaga wrote:
Hi David,
> You still removed the size bounds checks:
>
> 190 size_t value = parse_value(value_str);
> 191 if (value == SIZE_MAX || value > SIZE_MAX / K) {
> 192 errstream->print_cr("Invalid option: %s must be in range
21 matches
Mail list logo
