Hi,
On 05/04/2016 03:45 AM, David Holmes wrote:
On 4/05/2016 10:19 AM, Yasumasa Suenaga wrote:
Hi David, Marcus,
I would not have done that but instead used a temporary julong for the
parse result, then range check, then assign to the actual _rotate_size
etc with a cast.
Thanks.
However, I
On 4/05/2016 10:19 AM, Yasumasa Suenaga wrote:
Hi David, Marcus,
I would not have done that but instead used a temporary julong for the
parse result, then range check, then assign to the actual _rotate_size
etc with a cast.
Thanks.
However, I guess we will encounter error when we access to >
Hi David, Marcus,
I would not have done that but instead used a temporary julong for the parse
result, then range check, then assign to the actual _rotate_size etc with a
cast.
Thanks.
However, I guess we will encounter error when we access to > 2GB size file.
(Sorry, 4GB is incorrect.)
I d
On 3/05/2016 11:49 PM, Yasumasa Suenaga wrote:
This seems broken to me, we're passing &_rotate_size (a size_t*) to
atojulong() which takes a julong*. If sizeof(julong) > sizeof(size_t)
then that's a problem, no?
Thanks, Marcus!
Yes good catch. I would have hoped the compiler would have compla
Hi all,
Please review this.
This changeset moves redefine classes tracing to UL.
Bug: https://bugs.openjdk.java.net/browse/JDK-8153535
Webrev: http://cr.openjdk.java.net/~rehn/8153535/rev_01/webrev/
Passes testsuits
jdk/test/:jdk_jdi,hotspot/test/:hotspot_all,nsk.jvmti.testlist,nsk.jdi.testli
Thanks!
Dan
On 5/3/16 1:02 PM, serguei.spit...@oracle.com wrote:
+1
Thanks,
Serguei
On 5/3/16 11:50, Dmitry Samersoff wrote:
Dan,
Looks good for me.
-Dmitry
On 2016-05-03 21:47, Daniel D. Daugherty wrote:
Greetings,
I need a review of the following quarantine change:
http://cr.ope
+1
Thanks,
Serguei
On 5/3/16 11:50, Dmitry Samersoff wrote:
Dan,
Looks good for me.
-Dmitry
On 2016-05-03 21:47, Daniel D. Daugherty wrote:
Greetings,
I need a review of the following quarantine change:
http://cr.openjdk.java.net/~dcubed/8155958-webrev/0-jdk9-hs-hotspot/
RBT testing
Dan,
Looks good for me.
-Dmitry
On 2016-05-03 21:47, Daniel D. Daugherty wrote:
> Greetings,
>
>
> I need a review of the following quarantine change:
>
>
> http://cr.openjdk.java.net/~dcubed/8155958-webrev/0-jdk9-hs-hotspot/
>
>
> RBT testing is in progress to verify that fix does quarant
Greetings,
I need a review of the following quarantine change:
http://cr.openjdk.java.net/~dcubed/8155958-webrev/0-jdk9-hs-hotspot/
RBT testing is in progress to verify that fix does quarantine the
failing tests.
Thanks, in advance, for any comments, questions or suggestions.
Dan
Hi Marcus,
That's good, but then we shouldn't limit it to SIZE_MAX. The overflow check in
logFileOutput.cpp should be removed.
In Linux 32 bits system, we cannot open > 4GB size file because we do not pass
O_LARGEFILE.
(we use fopen(3))
In manpage [1], we should use _FILE_OFFSET_BITS rather
On 05/03/2016 03:49 PM, Yasumasa Suenaga wrote:
This seems broken to me, we're passing &_rotate_size (a size_t*) to
atojulong() which takes a julong*. If sizeof(julong) > sizeof(size_t)
then that's a problem, no?
Thanks, Marcus!
I changed type of _rotate_size and _current_size to julong in n
This seems broken to me, we're passing &_rotate_size (a size_t*) to atojulong()
which takes a julong*. If sizeof(julong) > sizeof(size_t) then that's a problem, no?
Thanks, Marcus!
I changed type of _rotate_size and _current_size to julong in new webrev:
http://cr.openjdk.java.net/~ysuenaga/
Hi,
On 05/03/2016 02:25 PM, David Holmes wrote:
Adding in the runtime team as they now own UL.
I've reviewed the change from a coding perspective - the question for
the UL owners is whether the change in semantics is appropriate:
previously the filesize was interpreted as a value in KB, wher
Adding in runtime.
David
On 3/05/2016 9:43 PM, Yasumasa Suenaga wrote:
PING: Could you review and sponsor it?
http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.01/
This patch makes to show option string of LogFileOutput.
Thanks,
Yasumasa
On 2016/04/19 22:55, Yasumasa Suenaga wr
Adding in the runtime team as they now own UL.
I've reviewed the change from a coding perspective - the question for
the UL owners is whether the change in semantics is appropriate:
previously the filesize was interpreted as a value in KB, whereas now,
without a suffix, it is just bytes.
Tha
PING: Could you review and sponsor it?
http://cr.openjdk.java.net/~ysuenaga/JDK-8153073/webrev.04/
Thanks,
Yasumasa
On 2016/04/21 18:37, Yasumasa Suenaga wrote:
Hi David,
So it just registered with me that currently filesize is interpreted as a value
in KB. With this change it will b
PING: Could you review and sponsor it?
http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.01/
This patch makes to show option string of LogFileOutput.
Thanks,
Yasumasa
On 2016/04/19 22:55, Yasumasa Suenaga wrote:
I adapted changes to jdk9/hs/hotspot repos.
http://cr.openjdk.jav
Hi Severin,
Please, find my comments below.
On 5/2/16 01:44, Severin Gehwolf wrote:
On Fri, 2016-04-29 at 12:33 -0700, serguei.spit...@oracle.com wrote:
On 4/29/16 01:56, Severin Gehwolf wrote:
Hi Serguei,
On Fri, 2016-04-29 at 01:34 -0700, serguei.spit...@oracle.com wrote:
Hi Severin,
Th
Hi,
Could I get a Reviewer to take a look at this please?
- Andreas
On 2016-04-21 19:35, Andreas Eriksson wrote:
On 2016-04-21 18:46, Erik Gahlin wrote:
On 2016-04-21 15:47, Andreas Eriksson wrote:
Hi,
On 2016-04-15 20:21, Erik Gahlin wrote:
Looks good, not a Reviewer.
Thanks.
Do y
19 matches
Mail list logo
