Re: PING: RFR: JDK-8155936: Boolean value should be set 1/0 or true/false via VM.set_flag jcmd

2016-05-17 Thread Gerard Ziemski
hi Yasumasa, We now have 2 reviewers, so I will push it in as soon as I get final testing results passing. cheers > On May 17, 2016, at 12:36 PM, Dmitry Samersoff > wrote: > > Yasumasa, > > Looks good for me. > > -Dmitry > > On 2016-05-17 17:31, Yasumasa Suenaga wrote: >> Hi Dmitry, >>

Re: PING: RFR: JDK-8155936: Boolean value should be set 1/0 or true/false via VM.set_flag jcmd

2016-05-17 Thread Dmitry Samersoff
Yasumasa, Looks good for me. -Dmitry On 2016-05-17 17:31, Yasumasa Suenaga wrote: > Hi Dmitry, > > Thank you for your comment. > I've fixed them in new webrev. Could you review again? > > http://cr.openjdk.java.net/~ysuenaga/JDK-8155936/webrev.01/ > > > Yasumasa > > > On 2016/05/17 19:25

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

2016-05-17 Thread Alex Henrie
I can see the change now at and , thank you. -Alex

Re: PING: RFR: JDK-8155936: Boolean value should be set 1/0 or true/false via VM.set_flag jcmd

2016-05-17 Thread Yasumasa Suenaga
Hi Dmitry, Thank you for your comment. I've fixed them in new webrev. Could you review again? http://cr.openjdk.java.net/~ysuenaga/JDK-8155936/webrev.01/ Yasumasa On 2016/05/17 19:25, Dmitry Samersoff wrote: Yasumasa, 1. Please use strcasecmp for true/false 2. You may save one strcmp ca

Re: PING: RFR: JDK-8155936: Boolean value should be set 1/0 or true/false via VM.set_flag jcmd

2016-05-17 Thread Dmitry Samersoff
Yasumasa, 1. Please use strcasecmp for true/false 2. You may save one strcmp call by replacing it to (*arg == '0' && *(arg+1) == 0) -Dmitry On 2016-05-17 13:15, Yasumasa Suenaga wrote: > PING: Could you review it? > We need a reviewer. > >> bug id: https://bugs.openjdk.java.net/browse/JDK-

PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

2016-05-17 Thread Yasumasa Suenaga
PING: Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.03/ Thanks, Yasumasa On 2016/05/10 8:06, Yasumasa Suenaga wrote: We need a second reviewer. Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.03/ Yasumasa On 2016/05/04

PING: RFR: JDK-8155936: Boolean value should be set 1/0 or true/false via VM.set_flag jcmd

2016-05-17 Thread Yasumasa Suenaga
PING: Could you review it? We need a reviewer. bug id: https://bugs.openjdk.java.net/browse/JDK-8155936 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8155936/webrev.00/ Thanks, Yasumasa On 2016/05/06 1:18, Gerard Ziemski wrote: I’m including serviceability mailing list. bug id: https: