Re: RFR: 8157555 com/sun/jdi/RedefineClearBreakpoint.sh times out due to Indify String Concat being slow in debug mode

2016-05-23 Thread Staffan Larsen
> On 23 maj 2016, at 23:39, serguei.spit...@oracle.com wrote: > > Staffan, > > I do not see any issues, the fix looks good to me. Thanks! > One question though. > > Where does the TESTTIMEOUTFACTOR environment variable come from? > I do not see it used anywhere in the jtreg tests. It is set

Re: RFR: 8157555 com/sun/jdi/RedefineClearBreakpoint.sh times out due to Indify String Concat being slow in debug mode

2016-05-23 Thread serguei.spit...@oracle.com
Staffan, I do not see any issues, the fix looks good to me. One question though. Where does the TESTTIMEOUTFACTOR environment variable come from? I do not see it used anywhere in the jtreg tests. Thanks, Serguei On 5/23/16 02:17, Staffan Larsen wrote: This is my second attempt at fixing this

RFR: 8157555 com/sun/jdi/RedefineClearBreakpoint.sh times out due to Indify String Concat being slow in debug mode

2016-05-23 Thread Staffan Larsen
This is my second attempt at fixing this timeout by taking the jtreg timeout factor into account in the tests. The first fix [1] looked at the wrong environment variable, and also would have caused the test to run unnecessarily slow since it set sleep_seconds to a higher value instead of changin