Re: RFR: 8157555 com/sun/jdi/RedefineClearBreakpoint.sh times out due to Indify String Concat being slow in debug mode

On 5/23/16 23:35, Staffan Larsen wrote: On 23 maj 2016, at 23:39, serguei.spit...@oracle.com wrote: Staffan, I do not see any issues, the fix looks good to me. Thanks! One question though. Where does the TESTTIMEOUTFACTOR environment variable come fro

Re: RFR: 8157555 com/sun/jdi/RedefineClearBreakpoint.sh times out due to Indify String Concat being slow in debug mode

On 5/24/16 00:01, serguei.spit...@oracle.com wrote: On 5/23/16 23:35, Staffan Larsen wrote: On 23 maj 2016, at 23:39, serguei.spit...@oracle.com wrote: Staffan, I do not see any issues, the fix looks good to me. Thanks! One question though. Where does the TESTTIMEOUTFACTOR environment v

Re: RFR: 8157555 com/sun/jdi/RedefineClearBreakpoint.sh times out due to Indify String Concat being slow in debug mode

> On 24 maj 2016, at 09:06, serguei.spit...@oracle.com wrote: > > On 5/24/16 00:01, serguei.spit...@oracle.com > wrote: >> On 5/23/16 23:35, Staffan Larsen wrote: >>> On 23 maj 2016, at 23:39, serguei.spit...@ora

Re: RFR: 8157555 com/sun/jdi/RedefineClearBreakpoint.sh times out due to Indify String Concat being slow in debug mode

On 5/24/16 00:08, Staffan Larsen wrote: On 24 maj 2016, at 09:06, serguei.spit...@oracle.com wrote: On 5/24/16 00:01, serguei.spit...@oracle.com wrote: On 5/23/16 23:35, Staffan Larsen wrote: On 23 maj 2016, at 23:39, serguei.spit...@oracle.com wrote:

Re: RFR: 8157555 com/sun/jdi/RedefineClearBreakpoint.sh times out due to Indify String Concat being slow in debug mode

Staffan, 37: It's better to write it as: timeout_factor=`echo $TESTTIMEOUTFACTOR | awk '{printf "%3.0f\n", $1}'` It uses the same synax as the rest of script and round value rather than truncate it. -Dmitry On 2016-05-23 12:17, Staffan Larsen wrote: > This is my second attempt

Re: RFR: 8157555 com/sun/jdi/RedefineClearBreakpoint.sh times out due to Indify String Concat being slow in debug mode

Yes, that would have been a little better. Unfortunately I have already pushed the change. Let me know if you think it is important enough to fix. /Staffan > On 24 maj 2016, at 10:42, Dmitry Samersoff > wrote: > > Staffan, > > 37: It's better to write it as: > > timeout_factor=`echo $TESTTI

Re: RFR: 8157555 com/sun/jdi/RedefineClearBreakpoint.sh times out due to Indify String Concat being slow in debug mode

Staffan, > Yes, that would have been a little better. Unfortunately I have > already pushed the change. Let me know if you think it is important > enough to fix. No, it's not so important. Sorry for being later. -Dmitry On 2016-05-24 12:00, Staffan Larsen wrote: > Yes, that would have been a li

RE: RFR[9u-dev]: 8150900: Implement diagnostic_pd

Hi,   I just wanted to let you know that since review there has been one new file added  “commandLineFlagWriteableList.cpp”,  and this files also needs to be modified/updated for implementing “diagnostic_pd”. This is just one additional change over what was reviewed before,  so I am  going ahe

Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd

hi Cheleswer, The change looks good. My understanding is that the jdk9 repo is now closed to features, so you will need an exception to push this fix - jesper.wilhelms...@oracle.com told me yesterday that the process for that is not ready/documented yet. cheers > On May 24, 2016, at 6:49 A

Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd

...although we consider this a fix, more than a feature, and hope it isn't excluded from being pushed. --- Kevin On 24/05/2016 17:24, Gerard Ziemski wrote: hi Cheleswer, The change looks good. My understanding is that the jdk9 repo is now closed to features, so you will need an exceptio

Re: RFR (M) 8155951: VM crash in nsk/jvmti/RedefineClasses/StressRedefine: assert failed: Corrupted constant pool

Finally caught up on this thread. The change looks great. I don't see any locking issues with this fix. Dan On 5/16/16 3:42 PM, Coleen Phillimore wrote: Thank you, David! Coleen On 5/16/16 4:59 PM, David Holmes wrote: Looks good! Thanks, David On 17/05/2016 2:28 AM, Coleen Phillimore wro

Re: RFR: 8153749 - New capability can_generate_early_class_hook_events

> Testing: >Altered the nsk.jvmti co-located test nsk/jvmti/ClassFileLoadHook/classfloadhk002 >to enable the can_generate_early_class_hook_events and checked that new CFLH events >are posted in the primordial phase and also they are not posted otherwise. Sorry for looping back on

Re: RFR: 8153749 - New capability can_generate_early_class_hook_events

On 5/24/16 16:23, Daniel D. Daugherty wrote: > Testing: >Altered the nsk.jvmti co-located test nsk/jvmti/ClassFileLoadHook/classfloadhk002 >to enable the can_generate_early_class_hook_events and checked that new CFLH events >are posted in the primordial phase and also they are not p

Re: RFR: 8153749 - New capability can_generate_early_class_hook_events

On 5/24/16 6:03 PM, serguei.spit...@oracle.com wrote: On 5/24/16 16:23, Daniel D. Daugherty wrote: > Testing: >Altered the nsk.jvmti co-located test nsk/jvmti/ClassFileLoadHook/classfloadhk002 >to enable the can_generate_early_class_hook_events and checked that new CFLH events >are

Re: RFR: 8153749 - New capability can_generate_early_class_hook_events

On 5/24/16 17:24, Daniel D. Daugherty wrote: On 5/24/16 6:03 PM, serguei.spit...@oracle.com wrote: On 5/24/16 16:23, Daniel D. Daugherty wrote: > Testing: >Altered the nsk.jvmti co-located test nsk/jvmti/ClassFileLoadHook/classfloadhk002 >to enable the can_generate_early_class_hook_eve

(S) RFR: 8154589: assert(k != NULL) failed: preloaded klass not initialized

Bug: https://bugs.openjdk.java.net/browse/JDK-8154589 webrev: http://cr.openjdk.java.net/~dholmes/8154589/webrev/ We sometimes see tests failing with a VM assertion failure that a klass was not loaded (the actual assertion message is wrong): # assert(k != NULL) failed: preloaded klass not ini

Re: (S) RFR: 8154589: assert(k != NULL) failed: preloaded klass not initialized

David, It looks good. Thanks, Serguei On 5/24/16 22:05, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8154589 webrev: http://cr.openjdk.java.net/~dholmes/8154589/webrev/ We sometimes see tests failing with a VM assertion failure that a klass was not loaded (the actual a

Re: (S) RFR: 8154589: assert(k != NULL) failed: preloaded klass not initialized

Thanks Serguei! David On 25/05/2016 3:41 PM, serguei.spit...@oracle.com wrote: David, It looks good. Thanks, Serguei On 5/24/16 22:05, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8154589 webrev: http://cr.openjdk.java.net/~dholmes/8154589/webrev/ We sometimes see te